Suppress assigned but unused variable warning#209
Merged
Conversation
Collaborator
|
Let me take a look at CI failures, which may be due to the Oracle database/client version differences. |
Collaborator
|
Adding similar change like this rsim/oracle-enhanced@05090c8 may address |
Collaborator
|
#210 addressed CI failures. Would you rebase from the latest master branch. |
Follow up to rsim#196. This PR suppresses the following `assigned but unused variable` warning. ```console ==> Running specs with ruby version 3.1.0 /home/travis/.rvm/gems/ruby-head/bundler/gems/ruby-plsql-b7f469a72bd7/lib/plsql/procedure.rb:234: warning: assigned but unused variable - object_name ==> Effective ActiveRecord version 7.0.0.alpha2 ``` https://app.travis-ci.com/github/rsim/oracle-enhanced/jobs/550436965
koic
force-pushed
the
suppress_unsed_variable_warning
branch
from
ecdca97 to
108f070
Compare
Collaborator
|
Going to merge this pull request because CI on GitHub Actions are green. Travis CI takes longer because it has a lot of version matrix. |
Collaborator
|
As a side note, we may need to run CI against Oracle 11g using https://github.com/gvenzl/oci-oracle-xe/blob/main/Dockerfile.11202 at GitHub Actions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #196.
This PR suppresses the following
assigned but unused variablewarning.https://app.travis-ci.com/github/rsim/oracle-enhanced/jobs/550436965