Skip to content

SDK_EXAMPLES uses the None returned by versions.update; wrappers.yml org-ID flags differ from roe-golang #91

Open

Description

@jadenfix

These files look like they're synced from the main repo by the release bot, so I'm filing this as an issue rather than a PR.

  1. SDK_EXAMPLES.md shows result = client.agents.versions.update(...), but AgentVersionsAPI.update returns None (src/roe/api/agents.py:220-226). agents.update returns the updated BaseAgent, so either the example or the return type should change.

    roe-python/SDK_EXAMPLES.md

    Lines 455 to 470 in 0881424

    #### `agents_versions_partial_update`
    Partially update an agent version.
    ```python
    from roe import RoeClient
    client = RoeClient()
    result = client.agents.versions.update(
    agent_id="agent_id", # required
    version_id="version_id", # required
    version_name="version_name", # optional
    description="description", # optional
    )
    ```
  2. openapi/wrappers.yml sets inject_organization_id differently from roe-golang's copy for the same endpoints. Python injects it on PUT /v1/agents/{agent_id}/ and PUT /v1/policies/{id}/, but Go doesn't. Go injects it on GET /v1/agents/, GET /v1/policies/ and POST /v1/policies/, but Python doesn't. One of the two is probably unintended.

Go counterpart: roe-ai/roe-golang#62

Note: testing this end to end requires a Roe API key, so I checked it against the code only.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions