Skip to content

docs: document proxy_ip_parser trusted_headers#76

Open
rustatian wants to merge 1 commit into
masterfrom
feature/proxy-trusted-headers
Open

docs: document proxy_ip_parser trusted_headers#76
rustatian wants to merge 1 commit into
masterfrom
feature/proxy-trusted-headers

Conversation

@rustatian

Copy link
Copy Markdown
Member

Documents the new http.trusted_headers option for the proxy_ip_parser middleware: an ordered allowlist of headers used to resolve the client IP (first non-empty match wins), the default order used when unset, and custom-header support.

Companion to roadrunner-server/proxy_ip_parser#120 (roadrunner-server/roadrunner#1515).

Document the new http.trusted_headers option: an ordered allowlist of headers
used to resolve the client IP (first non-empty match wins), the default order
when unset, and custom-header support.
Copilot AI review requested due to automatic review settings June 4, 2026 06:37
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@rustatian, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 43 minutes and 25 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 59ecdf99-2008-4da9-8f78-d15b691719c9

📥 Commits

Reviewing files that changed from the base of the PR and between 02bcb28 and 0641703.

📒 Files selected for processing (1)
  • http/proxy.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/proxy-trusted-headers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Proxy IP parser middleware documentation to describe how the client IP is resolved from proxy headers when requests come from trusted subnets, including the new trusted_headers configuration and its default behavior.

Changes:

  • Rewrites the intro/description to explain trusted-subnet gating and “first non-empty header wins” behavior.
  • Documents the default header precedence order used for client IP resolution.
  • Adds a new “Trusted headers” section with configuration example and parsing notes (RFC 7239 / X-Forwarded-For).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread http/proxy.md
Comment on lines +3 to +6
This middleware resolves the real client IP from proxy headers when a request arrives
through a trusted subnet. By default it consults, in order: `Forwarded`, `X-Forwarded-For`,
`X-Real-IP`, `True-Client-IP`, and `CF-Connecting-IP`. The set and order of headers can be
customized with `trusted_headers`.
Comment thread http/proxy.md
Comment on lines +54 to +55
For example, to trust only `X-Real-IP` and Cloudflare's `CF-Connecting-IP` while ignoring
`X-Forwarded-*`:
@rustatian rustatian self-assigned this Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants