Repository navigation
Conversation
When redirecting standard input from a file (e.g. < settings.json), Node's process.stdin stream emits an end event upon reaching EOF, but does not emit a close event. Because stdin() previously only listened for close, reading from file redirection left the Promise permanently unresolved. Node's event loop would drain after end, causing the process to exit silently with status code 0 without producing output. Listen on the end event instead of close so that both piped input and shell file redirection resolve properly. Assisted-by: Antigravity:gemini-3.6-flash Tested-by: Buo-ren Lin <buo.ren.lin@gmail.com> Signed-off-by: 林博仁(Buo-ren Lin) <buo.ren.lin@gmail.com>
brlin-tw
force-pushed
the
fix-shell-redirection-read
branch
from
August 15, 2026 07:07
8ff07c3 to
947c33c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When redirecting standard input from a file (e.g. < settings.json), Node's process.stdin stream emits an end event upon reaching EOF, but does not emit a close event.
Because stdin() previously only listened for close, reading from file redirection left the Promise permanently unresolved. Node's event loop would drain after end, causing the process to exit silently with status code 0 without producing output.
Listen on the end event instead of close so that both piped input and shell file redirection resolve properly.
Assisted-by: Antigravity:gemini-3.6-flash
Tested-by: Buo-ren Lin buo.ren.lin@gmail.com