Skip to content

ResourceNotFound with parameter length greater than 100 #1940

Open

Description

@urmilparikh

Restify Version: 11.0.0
Node.js Version: 14.15.3

Expected behaviour

Routing should work irrespective of params length

Actual behaviour

Routing works for params length up to 100, gives ResourceNotFound error for any longer

Repro case

    let restify = require('restify');
    let server = restify.createServer();

    server.get('/test/:data', function(req, res, next) {
        res.end(`Length: ${req.params.data.length}`);
        return next();
    });

    server.listen(80);

Works:
http://localhost/test/1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890

Generates ResourceNotFound error.
http://localhost/test/12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901

Cause

It seems there's a limit of 100 for params, which changed I think from v6 --> v7
A config option to increase this limit will be very helpful.

Are you willing and able to fix this?

No, but I can help test.

Activity

  1. imrago-medxnote commented on Aug 9, 2024

    @imrago-medxnote

    Had a similar issue, setting this parameter to a bigger value helped:

    const server = restify.createServer(
    { maxParamLength: 300 }
    );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions