Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pydantic model wrapper currently turns Restate SDK control-flow exceptions into a plain
Exception. That makes suspension and retry control paths look like ordinary model-call failures, so callers have to inspect__cause__to recover the real Restate exception.This keeps
SdkInternalBaseExceptionand its subclasses unchanged when they leave the journaled pydantic model call. The same change applies to streaming model calls. I left provider 4xx classification out because the issue proposes a policy, but there is no maintainer-confirmed mapping yet.Part of #225
Testing Done
Raw logs
Red, with the old wrapper implementation restored over the new regression test:
Green, after restoring this branch's wrapper implementation: