Repository navigation
Conversation
Changelog💅 Polish
Semantic Diff1 commit · Full page Make the build system's output wording, labels and colors consistent4c7e3d1 · cknitt + Claude · Nov 06, 2026, 21:08 UTC
Output modified (redirected rescript build)
-Cleaned 0/0
-Parsed 1 source files
-Compiled 1 modules
-Incremental build failed. Error: \e[2K\r Failed to Compile. See Errors Above
+Cleaned 0 stale modules
+Parsed 1 source file
+Compiled 1 module
+Build failed: see the errors above.Diagnostic modified (labels and wording)
-ERROR:
-Could not read folder: "nosuch". Specified in dependency: dep, located "<path>"...
-WARN:
-Package 'dep' has not defined any sources, …
-Duplicated package: a ./node_modules/a (chosen) vs … in ./node_modules/b
-\e[2K\r No implementation file found for interface file (skipping): src/B.resi
-Error in pkg:
-DEBUG:
-Compiling file: A
-compile dirty: A
-TRACE:
-Compiled 2 out of 2 in the universe
-… is not supported by ReScript 12's new build system.
-Could not start Rescript build: …
+warning: source folder "nosuch" of package dep (<path>) does not exist or is not a folder
+warning: package 'dep' has not defined any sources, …
+warning: duplicated package: a ./node_modules/a (chosen) vs … in ./node_modules/b
+warning: no implementation file found for interface file (skipping): src/B.resi
+(no header before parse errors)
+debug: Compiling file: A
+trace: compile dirty: A
+trace: compiled 2 of the 2 modules to check
+… is not supported by the ReScript build system.
+Could not start ReScript build: …The other changes: - a redirected one-shot build ends with Finished compilation, like watch; - compiler errors and warnings are printed without colors when colors are off (redirected output, NO_COLOR); .compiler.log keeps them for editors; - config diagnostics are separated by one blank line; - rescript clean labels its second step "generated files" when no output is in-source, instead of an empty suffix list; - the cleanup step no longer counts the previous ASTs, which only the Cleaned N/M line printed. Review
|
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abe9a7461d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Why:
The build system's messages still followed the Rust implementation's
output, which the OCaml one had to match exactly (#9244).
Output modified (redirected rescript build):
Before (text):
Cleaned 0/0
Parsed 1 source files
Compiled 1 modules
Incremental build failed. Error: \e[2K\r Failed to Compile. See Errors Above
After (text):
Cleaned 0 stale modules
Parsed 1 source file
Compiled 1 module
Build failed: see the errors above.
Diagnostic modified (labels and wording):
Before (text):
ERROR:
Could not read folder: "nosuch". Specified in dependency: dep, located "<path>"...
WARN:
Package 'dep' has not defined any sources, …
Duplicated package: a ./node_modules/a (chosen) vs … in ./node_modules/b
\e[2K\r No implementation file found for interface file (skipping): src/B.resi
Error in pkg:
DEBUG:
Compiling file: A
compile dirty: A
TRACE:
Compiled 2 out of 2 in the universe
… is not supported by ReScript 12's new build system.
Could not start Rescript build: …
After (text):
warning: source folder "nosuch" of package dep (<path>) does not exist or is not a folder
warning: package 'dep' has not defined any sources, …
warning: duplicated package: a ./node_modules/a (chosen) vs … in ./node_modules/b
warning: no implementation file found for interface file (skipping): src/B.resi
(no header before parse errors)
debug: Compiling file: A
trace: compile dirty: A
trace: compiled 2 of the 2 modules to check
… is not supported by the ReScript build system.
Could not start ReScript build: …
The other changes:
- a redirected one-shot build ends with Finished compilation, like watch;
- compiler errors and warnings are printed without colors when colors are
off (redirected output, NO_COLOR); .compiler.log keeps them for editors;
- config diagnostics are separated by one blank line;
- rescript clean labels its second step "generated files" when no output
is in-source, instead of an empty suffix list;
- the cleanup step no longer counts the previous ASTs, which only the
Cleaned N/M line printed.
Review: Why are config diagnostics still printed after the progress lines? Moving them before would restructure the report for little gain; only their spacing changes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Kbf3gGBR9g3DD93vrWbYzU
Signed-off-by: Christoph Knittel <ck@cca.io>
abe9a74 to
4c7e3d1
Compare
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Closes #9244. Stacked on the format fixes.
Rust-era output conventions replaced with the simplest consistent form:
Parsed 1 source file,Compiled 1 module). The cleanup step saysCleaned N stale modules; the/totalpart is gone, along with the counter that only fed it.Build failed: see the errors above.(or… could not parse the source files above.) replacesIncremental build failed. Error: \e[2K\r Failed to Compile. See Errors Above.Finished compilation, like watch mode.warning: …,debug: …,trace: …, instead ofERROR:/WARN:/DEBUG:/TRACE:on their own line. A missing dependency source folder is a warning (the build succeeds). The duplicate-package and orphan-interface warnings carry the label too, and the orphan one loses its line-clear sequence.Error in <package>:header, like type errors.NO_COLOR);.compiler.logkeeps them for editors.RescriptbecomesReScript;cleanwith no in-source output says "generated files".Left as is: config diagnostics are still printed after the progress lines; moving them would restructure the report.
The integration snapshots in
rewatch/tests/snapshotswere converted mechanically: colors stripped and the wording above applied. The local suite cannot run past the file-casing packages on this machine's Docker-for-Mac mount, so CI is the first full run of those snapshots.New test:
output_testscovers the singular counts and uncolored compiler output. The other updates are snapshot and expectation changes.🤖 Generated with Claude Code
https://claude.ai/code/session_01Kbf3gGBR9g3DD93vrWbYzU