Skip to content

TScert: print nested options by depth and polymorphic option code as overloads under -bs-emit-ts #9213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cristianoc wants to merge 3 commits into from
Draft

TScert: print nested options by depth and polymorphic option code as overloads under -bs-emit-ts #9213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c88be8
Print nested options by depth and polymorphic option code as overloads
cristianoc Nov 4, 2026
bd978bd
Print a marker of any depth at a payload that may own the marker key
cristianoc Nov 4, 2026
dc30f4e
Record tsc's diagnostics for the emit_ts examples: none with overloads
cristianoc Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion compiler/core/js_dump.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,38 @@ let rec pp_function ~return_unit ~async ~is_method ?directive cxt (f : P.t)
param_body ();
semi f
| Name_top x ->
if Js_ts_annot.export_inline x then (
let export = Js_ts_annot.export_inline x in
(* [-bs-emit-ts]: the function's overloads, each a declaration
without a body before the function, which carries its own
signature. An overload takes no [async]. *)
if Js_ts_annot.enabled () then
Ext_list.iter (Js_ts_annot.overloads x) (fun (typed, result) ->
if export then (
P.string f L.export;
P.space f);
P.string f (L.function_ ~async:false ~arrow:false);
ignore (Ext_pp_scope.ident inner_cxt f x : cxt);
P.string f (Js_ts_annot.type_params x);
ignore
(P.paren_group f 1 (fun _ ->
iter_lst inner_cxt f l
(fun cxt f id ->
let cxt = Ext_pp_scope.ident cxt f id in
(match Js_ts_annot.overload_param_type typed id with
| Some ty ->
P.string f ":";
P.space f;
P.string f ty
| None -> ());
cxt)
comma_sp)
: cxt);
P.string f ":";
P.space f;
P.string f result;
semi f;
P.newline f);
if export then (
P.string f L.export;
P.space f);
P.string f (L.function_ ~async ~arrow);
Expand Down
Loading
Loading