Vendor APT package caching for Linux CI#8513
Open
cknitt wants to merge 1 commit into
Open
Conversation
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8513 |
Member
Author
|
Supersedes #8507 |
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
awalsh128/cache-apt-pkgs-actionactions/cache@v6darcsandmercurialdependenciesWhy
The currently pinned
awalsh128/cache-apt-pkgs-action@v1.4.3uses GitHub Actions dependencies that run on the deprecated Node.js 20 runtime, causing deprecation warnings in CI. Newer versions avoid those warnings but break the Dune setup.Replacing it with
gerlero/apt-installremoves the warning and build failure, but cache hits still take over 20 seconds—roughly as long as an uncached installation.The old action’s filesystem-based cache restores the required files in only a few seconds. This vendors a small, repository-specific implementation of that approach while using
actions/cache@v6and avoiding the problematic upstream changes.On cache hits, CI only resolves the cache key, restores the cache, and extracts one tar archive.
apt-get updateand package installation run only on cache misses.