Skip to content

Remove Belt xxxUndefined API #8377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cknitt merged 1 commit into from
Apr 21, 2026
Merged

Remove Belt xxxUndefined API #8377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/@rescript/runtime/Belt_Array.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ external getUnsafe: (t<'a>, int) => 'a = "%array_unsafe_get"

external setUnsafe: (t<'a>, int, 'a) => unit = "%array_unsafe_set"

external getUndefined: (t<'a>, int) => Js.undefined<'a> = "%array_unsafe_get"

/* external get: 'a t -> int -> 'a = "%array_safe_get" */
let get = (arr, i) =>
if i >= 0 && i < length(arr) {
Expand Down
9 changes: 0 additions & 9 deletions packages/@rescript/runtime/Belt_Array.resi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,6 @@ no bounds checking; this would cause type error if `i` does not stay within rang
*/
external getUnsafe: (t<'a>, int) => 'a = "%array_unsafe_get"

/**
`getUndefined(arr, i)`

It does the samething in the runtime as [`getUnsafe`]();
it is _type safe_ since the return type still track whether it is
in range or not
*/
external getUndefined: (t<'a>, int) => Js.undefined<'a> = "%array_unsafe_get"

/**
`set(arr, n, x)` modifies `arr` in place; it replaces the nth element of `arr`
with `x`. Returning `false` means not updated due to out of range.
Expand Down
6 changes: 0 additions & 6 deletions packages/@rescript/runtime/Belt_Map.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,18 +101,12 @@ let toArray = m => Dict.toArray(m.data)
let keysToArray = m => Dict.keysToArray(m.data)
let valuesToArray = m => Dict.valuesToArray(m.data)
let minKey = m => Dict.minKey(m.data)
let minKeyUndefined = m => Dict.minKeyUndefined(m.data)
let maxKey = m => Dict.maxKey(m.data)
let maxKeyUndefined = m => Dict.maxKeyUndefined(m.data)
let minimum = m => Dict.minimum(m.data)
let minUndefined = m => Dict.minUndefined(m.data)
let maximum = m => Dict.maximum(m.data)
let maxUndefined = m => Dict.maxUndefined(m.data)

let get = (map, x) => Dict.get(~cmp=map.cmp, map.data, x)

let getUndefined = (map, x) => Dict.getUndefined(~cmp=map.cmp, map.data, x)

let getWithDefault = (map, x, def) => Dict.getWithDefault(~cmp=map.cmp, map.data, x, def)

let getOrThrow = (map, x) => Dict.getOrThrow(~cmp=map.cmp, map.data, x)
Expand Down
15 changes: 0 additions & 15 deletions packages/@rescript/runtime/Belt_Map.resi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,27 +295,15 @@ let valuesToArray: t<'k, 'v, 'id> => array<'v>
/** `minKey(s)` returns the minimum key, None if not exist. */
let minKey: t<'k, _, _> => option<'k>

/** See `Belt.Map.minKey` */
let minKeyUndefined: t<'k, _, _> => Js.undefined<'k>

/** `maxKey(s)` returns the maximum key, None if not exist. */
let maxKey: t<'k, _, _> => option<'k>

/** See `Belt.Map.maxKey` */
let maxKeyUndefined: t<'k, _, _> => Js.undefined<'k>

/** `minimum(s)` returns the minimum key value pair, None if not exist. */
let minimum: t<'k, 'v, _> => option<('k, 'v)>

/** See `Belt.Map.minimum` */
let minUndefined: t<'k, 'v, _> => Js.undefined<('k, 'v)>

/** `maximum(s)` returns the maximum key value pair, None if not exist. */
let maximum: t<'k, 'v, _> => option<('k, 'v)>

/** See `Belt.Map.maximum` */
let maxUndefined: t<'k, 'v, _> => Js.undefined<('k, 'v)>

/**
`get(s, k)`

Expand All @@ -334,9 +322,6 @@ Belt.Map.get(Belt.Map.fromArray([(2, "2"), (1, "1"), (3, "3")], ~id=module(IntCm
*/
let get: (t<'k, 'v, 'id>, 'k) => option<'v>

/** See `Belt.Map.get`. Returns `undefined` when not found*/
let getUndefined: (t<'k, 'v, 'id>, 'k) => Js.undefined<'v>

/**
`getWithDefault(s, k, default)`

Expand Down
5 changes: 0 additions & 5 deletions packages/@rescript/runtime/Belt_MapDict.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,7 @@ let minimum = N.minimum
let maximum = N.maximum
let minKey = N.minKey
let maxKey = N.maxKey
let minKeyUndefined = N.minKeyUndefined
let maxKeyUndefined = N.maxKeyUndefined
let minUndefined = N.minUndefined
let maxUndefined = N.maxUndefined
let get = N.get
let getUndefined = N.getUndefined
let getWithDefault = N.getWithDefault
let getOrThrow = N.getOrThrow
let getExn = getOrThrow
Expand Down
10 changes: 0 additions & 10 deletions packages/@rescript/runtime/Belt_MapDict.resi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,24 +115,14 @@ let valuesToArray: t<'k, 'a, 'id> => array<'a>

let minKey: t<'k, _, _> => option<'k>

let minKeyUndefined: t<'k, _, _> => Js.undefined<'k>

let maxKey: t<'k, _, _> => option<'k>

let maxKeyUndefined: t<'k, _, _> => Js.undefined<'k>

let minimum: t<'k, 'a, _> => option<('k, 'a)>

let minUndefined: t<'k, 'a, _> => Js.undefined<('k, 'a)>

let maximum: t<'k, 'a, _> => option<('k, 'a)>

let maxUndefined: t<'k, 'a, _> => Js.undefined<('k, 'a)>

let get: (t<'k, 'a, 'id>, 'k, ~cmp: cmp<'k, 'id>) => option<'a>

let getUndefined: (t<'k, 'a, 'id>, 'k, ~cmp: cmp<'k, 'id>) => Js.undefined<'a>

let getWithDefault: (t<'k, 'a, 'id>, 'k, 'a, ~cmp: cmp<'k, 'id>) => 'a

let getExn: (t<'k, 'a, 'id>, 'k, ~cmp: cmp<'k, 'id>) => 'a
Expand Down
5 changes: 0 additions & 5 deletions packages/@rescript/runtime/Belt_MapInt.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,9 @@ let isEmpty = N.isEmpty
/* let singleton = N.singleton */

let minKey = N.minKey
let minKeyUndefined = N.minKeyUndefined
let maxKey = N.maxKey
let maxKeyUndefined = N.maxKeyUndefined
let minimum = N.minimum
let minUndefined = N.minUndefined
let maximum = N.maximum
let maxUndefined = N.maxUndefined
let findFirstBy = N.findFirstBy
let forEach = N.forEach
let map = N.map
Expand Down Expand Up @@ -169,7 +165,6 @@ let has = I.has
let cmp = I.cmp
let eq = I.eq
let get = I.get
let getUndefined = I.getUndefined
let getWithDefault = I.getWithDefault
let getOrThrow = I.getOrThrow
let getExn = getOrThrow
Expand Down
10 changes: 0 additions & 10 deletions packages/@rescript/runtime/Belt_MapInt.resi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,24 +92,14 @@ let valuesToArray: t<'v> => array<'v>

let minKey: t<_> => option<key>

let minKeyUndefined: t<_> => Js.undefined<key>

let maxKey: t<_> => option<key>

let maxKeyUndefined: t<_> => Js.undefined<key>

let minimum: t<'v> => option<(key, 'v)>

let minUndefined: t<'v> => Js.undefined<(key, 'v)>

let maximum: t<'v> => option<(key, 'v)>

let maxUndefined: t<'v> => Js.undefined<(key, 'v)>

let get: (t<'v>, key) => option<'v>

let getUndefined: (t<'v>, key) => Js.undefined<'v>

let getWithDefault: (t<'v>, key, 'v) => 'v

let getExn: (t<'v>, key) => 'v
Expand Down
5 changes: 0 additions & 5 deletions packages/@rescript/runtime/Belt_MapString.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,9 @@ let isEmpty = N.isEmpty
/* let singleton = N.singleton */

let minKey = N.minKey
let minKeyUndefined = N.minKeyUndefined
let maxKey = N.maxKey
let maxKeyUndefined = N.maxKeyUndefined
let minimum = N.minimum
let minUndefined = N.minUndefined
let maximum = N.maximum
let maxUndefined = N.maxUndefined
let findFirstBy = N.findFirstBy
let forEach = N.forEach
let map = N.map
Expand Down Expand Up @@ -169,7 +165,6 @@ let has = I.has
let cmp = I.cmp
let eq = I.eq
let get = I.get
let getUndefined = I.getUndefined
let getWithDefault = I.getWithDefault
let getOrThrow = I.getOrThrow
let getExn = getOrThrow
Expand Down
10 changes: 0 additions & 10 deletions packages/@rescript/runtime/Belt_MapString.resi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,24 +92,14 @@ let valuesToArray: t<'v> => array<'v>

let minKey: t<_> => option<key>

let minKeyUndefined: t<_> => Js.undefined<key>

let maxKey: t<_> => option<key>

let maxKeyUndefined: t<_> => Js.undefined<key>

let minimum: t<'v> => option<(key, 'v)>

let minUndefined: t<'v> => Js.undefined<(key, 'v)>

let maximum: t<'v> => option<(key, 'v)>

let maxUndefined: t<'v> => Js.undefined<(key, 'v)>

let get: (t<'v>, key) => option<'v>

let getUndefined: (t<'v>, key) => Js.undefined<'v>

let getWithDefault: (t<'v>, key, 'v) => 'v

let getExn: (t<'v>, key) => 'v
Expand Down
6 changes: 0 additions & 6 deletions packages/@rescript/runtime/Belt_MutableMap.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,9 @@ let clear = m => m.data = None
let isEmpty = d => N.isEmpty(d.data)

let minKey = m => N.minKey(m.data)
let minKeyUndefined = m => N.minKeyUndefined(m.data)
let maxKey = m => N.maxKey(m.data)
let maxKeyUndefined = m => N.maxKeyUndefined(m.data)
let minimum = m => N.minimum(m.data)
let minUndefined = m => N.minUndefined(m.data)
let maximum = m => N.maximum(m.data)
let maxUndefined = m => N.maxUndefined(m.data)

let forEach = (d, f) => N.forEach(d.data, f)
let reduce = (d, acc, cb) => N.reduce(d.data, acc, cb)
Expand All @@ -168,8 +164,6 @@ let map = (m, f) => {cmp: m.cmp, data: N.map(m.data, f)}
let mapWithKey = (m, f) => {cmp: m.cmp, data: N.mapWithKey(m.data, f)}
let get = (m, x) => N.get(~cmp=m.cmp, m.data, x)

let getUndefined = (m, x) => N.getUndefined(~cmp=m.cmp, m.data, x)

let getWithDefault = (m, x, def) => N.getWithDefault(~cmp=m.cmp, m.data, x, def)

let getOrThrow = (m, x) => N.getOrThrow(~cmp=m.cmp, m.data, x)
Expand Down
5 changes: 0 additions & 5 deletions packages/@rescript/runtime/Belt_MutableMap.resi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,10 @@ let fromArray: (array<('k, 'a)>, ~id: id<'k, 'id>) => t<'k, 'a, 'id>
let keysToArray: t<'k, _, _> => array<'k>
let valuesToArray: t<_, 'a, _> => array<'a>
let minKey: t<'k, _, _> => option<'k>
let minKeyUndefined: t<'k, _, _> => Js.undefined<'k>
let maxKey: t<'k, _, _> => option<'k>
let maxKeyUndefined: t<'k, _, _> => Js.undefined<'k>
let minimum: t<'k, 'a, _> => option<('k, 'a)>
let minUndefined: t<'k, 'a, _> => Js.undefined<('k, 'a)>
let maximum: t<'k, 'a, _> => option<('k, 'a)>
let maxUndefined: t<'k, 'a, _> => Js.undefined<('k, 'a)>
let get: (t<'k, 'a, 'id>, 'k) => option<'a>
let getUndefined: (t<'k, 'a, 'id>, 'k) => Js.undefined<'a>
let getWithDefault: (t<'k, 'a, 'id>, 'k, 'a) => 'a
let getExn: (t<'k, 'a, 'id>, 'k) => 'a
let getOrThrow: (t<'k, 'a, 'id>, 'k) => 'a
Expand Down
5 changes: 0 additions & 5 deletions packages/@rescript/runtime/Belt_MutableMapInt.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,10 @@ let isEmpty = m => N.isEmpty(m.data)
let clear = m => m.data = None
/* let singleton k v = t ~data:(N.singleton k v) */

let minKeyUndefined = m => N.minKeyUndefined(m.data)
let minKey = m => N.minKey(m.data)
let maxKeyUndefined = m => N.maxKeyUndefined(m.data)
let maxKey = m => N.maxKey(m.data)
let minimum = m => N.minimum(m.data)
let minUndefined = m => N.minUndefined(m.data)
let maximum = m => N.maximum(m.data)
let maxUndefined = m => N.maxUndefined(m.data)

let set = (m: t<_>, k, v) => {
let old_data = m.data
Expand Down Expand Up @@ -163,7 +159,6 @@ let cmp = (d0, d1, f) => I.cmp(d0.data, d1.data, f)
let eq = (d0, d1, f) => I.eq(d0.data, d1.data, f)

let get = (d, x) => I.get(d.data, x)
let getUndefined = (d, x) => I.getUndefined(d.data, x)
let getWithDefault = (d, x, def) => I.getWithDefault(d.data, x, def)
let getOrThrow = (d, x) => I.getOrThrow(d.data, x)
let getExn = getOrThrow
Expand Down
5 changes: 0 additions & 5 deletions packages/@rescript/runtime/Belt_MutableMapInt.resi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,10 @@ let fromArray: array<(key, 'a)> => t<'a>
let keysToArray: t<'a> => array<key>
let valuesToArray: t<'a> => array<'a>
let minKey: t<_> => option<key>
let minKeyUndefined: t<_> => Js.undefined<key>
let maxKey: t<_> => option<key>
let maxKeyUndefined: t<_> => Js.undefined<key>
let minimum: t<'a> => option<(key, 'a)>
let minUndefined: t<'a> => Js.undefined<(key, 'a)>
let maximum: t<'a> => option<(key, 'a)>
let maxUndefined: t<'a> => Js.undefined<(key, 'a)>
let get: (t<'a>, key) => option<'a>
let getUndefined: (t<'a>, key) => Js.undefined<'a>
let getWithDefault: (t<'a>, key, 'a) => 'a
let getExn: (t<'a>, key) => 'a
let getOrThrow: (t<'a>, key) => 'a
Expand Down
5 changes: 0 additions & 5 deletions packages/@rescript/runtime/Belt_MutableMapString.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,10 @@ let isEmpty = m => N.isEmpty(m.data)
let clear = m => m.data = None
/* let singleton k v = t ~data:(N.singleton k v) */

let minKeyUndefined = m => N.minKeyUndefined(m.data)
let minKey = m => N.minKey(m.data)
let maxKeyUndefined = m => N.maxKeyUndefined(m.data)
let maxKey = m => N.maxKey(m.data)
let minimum = m => N.minimum(m.data)
let minUndefined = m => N.minUndefined(m.data)
let maximum = m => N.maximum(m.data)
let maxUndefined = m => N.maxUndefined(m.data)

let set = (m: t<_>, k, v) => {
let old_data = m.data
Expand Down Expand Up @@ -163,7 +159,6 @@ let cmp = (d0, d1, f) => I.cmp(d0.data, d1.data, f)
let eq = (d0, d1, f) => I.eq(d0.data, d1.data, f)

let get = (d, x) => I.get(d.data, x)
let getUndefined = (d, x) => I.getUndefined(d.data, x)
let getWithDefault = (d, x, def) => I.getWithDefault(d.data, x, def)
let getOrThrow = (d, x) => I.getOrThrow(d.data, x)
let getExn = getOrThrow
Expand Down
5 changes: 0 additions & 5 deletions packages/@rescript/runtime/Belt_MutableMapString.resi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,10 @@ let fromArray: array<(key, 'a)> => t<'a>
let keysToArray: t<'a> => array<key>
let valuesToArray: t<'a> => array<'a>
let minKey: t<_> => option<key>
let minKeyUndefined: t<_> => Js.undefined<key>
let maxKey: t<_> => option<key>
let maxKeyUndefined: t<_> => Js.undefined<key>
let minimum: t<'a> => option<(key, 'a)>
let minUndefined: t<'a> => Js.undefined<(key, 'a)>
let maximum: t<'a> => option<(key, 'a)>
let maxUndefined: t<'a> => Js.undefined<(key, 'a)>
let get: (t<'a>, key) => option<'a>
let getUndefined: (t<'a>, key) => Js.undefined<'a>
let getWithDefault: (t<'a>, key, 'a) => 'a
let getExn: (t<'a>, key) => 'a
let getOrThrow: (t<'a>, key) => 'a
Expand Down
24 changes: 0 additions & 24 deletions packages/@rescript/runtime/Belt_MutableQueue.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,6 @@ let peek = q =>
| Some(v) => Some(v.content)
}

let peekUndefined = q =>
switch q.first {
| None => Js.undefined
| Some(v) => Js.Undefined.return(v.content)
}

let peekOrThrow = q =>
switch q.first {
| None => throw(Not_found)
Expand All @@ -85,13 +79,11 @@ let pop = q =>
}

let popOrThrow = q =>
/* TO fix */
switch q.first {
| None => throw(Not_found)
| Some(x) =>
let next = x.next
if next == None {
/* only one element */
clear(q)
x.content
} else {
Expand All @@ -103,22 +95,6 @@ let popOrThrow = q =>

let popExn = popOrThrow

let popUndefined = q =>
switch q.first {
| None => Js.undefined
| Some(x) =>
let next = x.next
if next == None {
/* only one element */
clear(q)
Js.Undefined.return(x.content)
} else {
q.length = q.length - 1
q.first = next
Js.Undefined.return(x.content)
}
}

let rec copyAux = (qRes, prev, cell) =>
switch cell {
| None =>
Expand Down
Loading
Loading