Fix migration to RegExp.Result.captures#8032
Open
DZakh wants to merge 1 commit into
Open
Conversation
Member
|
You need to update the test fixtures as well. |
Member
plus rebase and CHANGELOG entry (rc.6; will change to final when actually building the release) |
Member
|
@DZakh think you could finish this up? |
Member
Author
|
Got stuck on a completely outdated local environment. Didn't have time to make it run yet |
Member
Author
|
Ah, also remembered that there were no way to correctly create an automated migration from value->Re.matches to value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing #8029
This was unsettling me, so I decided to create a PR to fix the binding and remove the broken migraiton.