Repository navigation
Replace "raise" in tests with "throw"; treat "throw" like "raise" in analysis - #7521
Merged
Merged
Conversation
rescript
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/darwin-arm64
@rescript/win32-x64
commit: |
cristianoc
approved these changes
May 26, 2025
cristianoc
left a comment
cristianoc
left a comment
Collaborator
There was a problem hiding this comment.
Looks good.
I was wondering about whether formatting raise to throw would be useful, but then there's the risk that a function with that name gets redefined user-side, and formatting would break it.
aspeddro
pushed a commit
to aspeddro/rescript-compiler
that referenced
this pull request
Oct 31, 2026
…analysis (rescript-lang#7521) * Replace "raise" in tests with "throw" * Treat "throw" like "raise" in analysis * Remove raise_notrace * Update syntax roundtrip tests * CHANGELOG Signed-off-by: Pedro Castro <aspeddro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.