Repository navigation
[Docs] Eval on checkbox toggle on - #644
Merged
Merged
Conversation
Member
|
This looks good to me, but there are merge conflicts |
Member
Author
|
Ah because #645 got merged first, sec. |
(I also changed the "Eval" label into "Evaluate" instead. Slightly clearer for newcomers that it's not a technical OCaml concept e.g. "turn on eval").
chenglou
force-pushed
the
eval-upon-click
branch
from
August 15, 2016 19:07
ba207ad to
d8ec6d8
Compare
Member
Author
|
Done. Whitespace-insensitive diff view: https://github.com/bloomberg/bucklescript/pull/644/files?w=1 |
Member
|
Thanks, FYI, I am working on sharing the same code base (#611) between reason and OCaml playground |
Member
Author
|
Hah, thanks for notifying, because I was gonna work on that right now. Would a toggle be enough? On the same page? Edit: just saw your dropdown comment. Cool! |
Member
|
I think so -- would you mind split some workload, I will create a submodule to upgrade reason parser, is that good? |
Member
Author
|
I'll put the toggle and make it work with the existent code? |
Member
|
Also the reason examples need be updated too |
cknitt
added a commit
that referenced
this pull request
Oct 23, 2026
…es (#8990) Why: The same logic was kept in several copies that had to change together. Misc.find_map_in_path_uncap is now the one "name as written, then uncapitalized" lookup, used by Misc.find_in_path_uncap, Config_util and Bs_cmi_load (#8925 had changed all three). Editor completion prints polyvariant labels with Res_printer.print_poly_var_ident instead of a copy of the printer's classifier, which had drifted. Lam_check and Lam_dce use Hash_ident, which Hash_set_ident duplicated since #8787. Format modified (completion label of a polymorphic variant): Example: type t = [#644 | #""] let f = (e: t) => ignore(e) // f() // ^com Before (text): #"644" # After (text): #644 #"" Claude-Session: https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe Signed-off-by: Christoph Knittel <ck@cca.io> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
aspeddro
pushed a commit
to aspeddro/rescript-compiler
that referenced
this pull request
Oct 31, 2026
…es (rescript-lang#8990) Why: The same logic was kept in several copies that had to change together. Misc.find_map_in_path_uncap is now the one "name as written, then uncapitalized" lookup, used by Misc.find_in_path_uncap, Config_util and Bs_cmi_load (rescript-lang#8925 had changed all three). Editor completion prints polyvariant labels with Res_printer.print_poly_var_ident instead of a copy of the printer's classifier, which had drifted. Lam_check and Lam_dce use Hash_ident, which Hash_set_ident duplicated since rescript-lang#8787. Format modified (completion label of a polymorphic variant): Example: type t = [rescript-lang#644 | #""] let f = (e: t) => ignore(e) // f() // ^com Before (text): #"644" # After (text): rescript-lang#644 #"" Claude-Session: https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe Signed-off-by: Christoph Knittel <ck@cca.io> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Pedro Castro <aspeddro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editor happened to strip the trailing whitespace if you don't mind.
(I also changed the "Eval" label into "Evaluate" instead. Slightly clearer for newcomers that it's not a technical OCaml concept e.g. "turn on eval").