Merged
Conversation
markphelps
added a commit
that referenced
this pull request
Mar 26, 2026
…add comment for health-only path - Fix double is_enabled() check in init_sentry() (reviewer issue #3) - Use ring crypto provider instead of aws-lc-rs to avoid cmake build dependency. Add rustls with ring feature explicitly, use reqwest's rustls-no-provider feature, and export install_crypto_provider() from coglet core (reviewer issue #7) - Remove sentry's rustls feature (reqwest already configures TLS) - Add install_crypto_provider() call to serve_impl() and webhook tests - Add comment explaining intentional omission of configure_sentry_scope in health-only path (reviewer issue #6) - Note: reqwest 0.13 with rustls-platform-verifier uses platform-native certificate verification, equivalent to the old rustls-tls-native-roots behavior (reviewer issue #4 — confirmed not a regression)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
…2865) * feat(coglet): add Sentry error reporting for infrastructure errors Report infrastructure-level errors to Sentry when SENTRY_DSN is set. Uses the sentry tracing layer to automatically capture ERROR-level tracing events (setup failures, worker crashes, IPC errors) as Sentry issues and WARN-level events as breadcrumbs. Zero overhead when no DSN is configured. Also upgrades reqwest from 0.12 to 0.13 to share the same version with the sentry SDK and avoid duplicate dependencies. * remove is_train from Sentry scope enrichment * address review feedback: fix double check, use ring crypto provider, add comment for health-only path - Fix double is_enabled() check in init_sentry() (reviewer issue #3) - Use ring crypto provider instead of aws-lc-rs to avoid cmake build dependency. Add rustls with ring feature explicitly, use reqwest's rustls-no-provider feature, and export install_crypto_provider() from coglet core (reviewer issue #7) - Remove sentry's rustls feature (reqwest already configures TLS) - Add install_crypto_provider() call to serve_impl() and webhook tests - Add comment explaining intentional omission of configure_sentry_scope in health-only path (reviewer issue #6) - Note: reqwest 0.13 with rustls-platform-verifier uses platform-native certificate verification, equivalent to the old rustls-tls-native-roots behavior (reviewer issue #4 — confirmed not a regression) --------- Co-authored-by: Michael Dwan <code@michaeldwan.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the project directory:
Anywhere else: