fix: stale weight digest reuse in WeightBuilder cache invalidation#2889
Open
erayack wants to merge 2 commits intoreplicate:mainfrom
Open
fix: stale weight digest reuse in WeightBuilder cache invalidation#2889erayack wants to merge 2 commits intoreplicate:mainfrom
erayack wants to merge 2 commits intoreplicate:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix stale weight digest reuse in
WeightBuildercache invalidation.What changed
SourceMtimeUnixNanotoWeightFile(sourceMtimeUnixNano,omitempty).name + size + sourceMtimeUnixNano(not justname + size).sourceMtimeUnixNanowith digest/size entries.Compatibility
Scope
weights build,weights push, OCI-index build path).weights inspect, pusher logic, or OCI annotations.Tests
pkg/model/weight_builder_test.gocache tests to cover mtime-aware hit/miss behavior.sourceMtimeUnixNanofield.integration-tests/harness/harness.go.