Skip to content

Watch for failures and timeouts when replaying recordings - #35

Merged
bhackett1024 merged 1 commit into
masterfrom
replay-failure
Feb 1, 2022
Merged

bhackett1024 merged 1 commit into
masterfrom
replay-failure

Conversation

@bhackett1024

Copy link
Copy Markdown

We can handle hangs while recording now, but hangs or session errors while replaying cause the test script to hang as well.

@bhackett1024
bhackett1024 requested a review from jazzdan February 1, 2022 20:09

@jazzdan jazzdan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bhackett1024
bhackett1024 merged commit 328df54 into master Feb 1, 2022
@bhackett1024
bhackett1024 deleted the replay-failure branch February 1, 2022 21:48
Domiii added a commit that referenced this pull request Aug 1, 2026
* RQD-16: install yarn before immer SeedInstall in test-jest.

BK agents have npm but not yarn; build #35 died with exit 127.

* RQD-16: use npx yarn for SeedInstall (no global npm -g).

Build #36 hit EACCES writing /usr/local/lib/node_modules/yarn.

* RQD-16: seed immer with pnpm import + frozen install.

Replace yarn. ImmerPin has yarn.lock only; import then install --frozen-lockfile.

* RQD-16: plain pnpm install for immer seed — no import/frozen.

Drop yarn.lock and resolve from package.json. Fresh mktemp seed each job.

* RQD-16: vendor immer pnpm lock + hoisted frozen seed.

Default pnpm layout breaks ts-jest on ImmerPin; write hoisted .npmrc in CI.

* RQD-16: revert pnpm seed — use ImmerPin yarn.lock via npx yarn.

Owners ship yarn; keep their lock. Agents lack yarn so use npx yarn@1.22.22.

* RQD-16: artifact_paths build_id; pin backend LocalReplay tip.

Publish host build_id for test-suite/test-jest. Point REPLAY_BACKEND_REV
at the paired backend BRANCH tip.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-16: pin backend tip without uploadBuildIdArtifact.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-16: pin backend tip with LocalReplay CrashReport capture.

* RQD-16: assert InternalModuleStat / OnUvRead / SpinEventLoop.

Surface hidden LocalReplay mismatches (I4 gettimeofday vs syscall) as proper
Assert mismatches. Pin backend tip with test-jest ENABLE_ASSERTS.

* RQD-16: pin backend tip with CrashReport recording upload.

* RQD-16: export Asserts envars in test-suite and test-jest BK steps.

Pin backend tip that also sets them in the harness record spawn paths.

* RQD-16: BK linker zombie sweeps; pin backend LinkerZombieLeak tip.

Run kill-linker-processes before test work and on EXIT for test-suite/test-jest; pin REPLAY_BACKEND_REV to the CI LocalReplay kill helper.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-16: route tests to can_replay; drop Build node size=large.

beefmaster (deploy+size=large) is gone so Build node never scheduled; tests that LocalReplay need can_replay agents.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-16: pin backend tip after merge of chromium master rev.

REPLAY_BACKEND_REV → de492429fe (contains chromium master 297cba1bc3 + RQD-16 LinkerZombieLeak).

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-16: pin Build node to size=large (beefmaster).

t3a.medium deploy agents OOMing mid-compile; beefmaster is back with deploy+size=large.

* RQD-16: point test-suite random tests at the BK node checkout.

Without RECORD_REPLAY_NODE_PATH, nodePath() misses test/ and random tests
crash on an empty list while still exiting 0.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-16: pin backend tip with random-test failure fix.

REPLAY_BACKEND_REV → d364b1bcf6 (fail empty random-test list / unhandled rejection).

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-16: pin backend tip with FailEager + listTests cache.

REPLAY_BACKEND_REV → 3602584447.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-16: pin backend tip after linkerdebug stash restore.

REPLAY_BACKEND_REV → 266abf96d5.

* RQD-16: port Chromium replayio.h / SingleAutoHome into Node V8.

* RQD-16: skip prepareStackTrace under DisallowEvents; pin backend tip.

REPLAY_BACKEND_REV → bf7e0b8149.

* RQD-16: rename BK test-suite→test-node; pin quieter default-suite sample.

REPLAY_BACKEND_REV → 4897de0c7c.

* RQD-16: pin backend tip with KillLinkerProcesses memUsedPct.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-16: pin REPLAY_BACKEND_REV to merged backend master tip.

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants