Pin PYTHONHASHSEED in the benchmark workflow - #6993
Merged
masenf merged 1 commit intoAug 28, 2026
Merged
Conversation
Randomized string hashing changes dict probe sequences from run to run, so the instrumented benchmarks can report a few percent of drift on a commit that never touched the measured code path.
Contributor
Greptile SummaryPins
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The fixed hash seed consistently applies to benchmark runs as intended, while no workflow consumer was found that requires randomized Python hashing.
|
| Filename | Overview |
|---|---|
| .github/workflows/performance.yml | Adds a documented deterministic Python hash seed without introducing a concrete workflow failure or violating repository rules. |
Reviews (1): Last reviewed commit: "Pin PYTHONHASHSEED in the benchmark work..." | Re-trigger Greptile
Merging this PR will not alter performance
Comparing Footnotes
|
6 tasks
masenf
approved these changes
Aug 28, 2026
masenf
pushed a commit
that referenced
this pull request
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python randomizes string hashing per process, so dict probe sequences differ between two runs of the same code. The instrumented benchmarks are sensitive enough to pick that up as a few percent of drift on a commit that never touched the measured code path, which makes real regressions harder to spot.
Pinning
PYTHONHASHSEED: 0for the workflow removes that source of run-to-run variation.CodSpeed doesn't call out
PYTHONHASHSEEDspecifically, but this is the same idea as their Keep Benchmarks Deterministic guidance, applied to the interpreter rather than to the benchmark body. Their write-up on unrelated benchmark regressions covers the wider class of environment-driven drift this belongs to.Only the workflow env changes; no package source is touched.