DO NOT MERGE - Codspeed run only - Rel fix pep695 alias runtime perf isinstance - #6988
Closed
benedikt-bartscher wants to merge 10 commits into
Closed
Conversation
PR reflex-dev#6944 added resolve_type_alias() but wired it only into Var.guess_type, so alias-annotated state vars compiled while every runtime path that re-checks the raw annotation still choked on the TypeAliasType: - State.__setattr__ validates assignments through _isinstance(), which fell through to the bare isinstance() call and raised "TypeError: isinstance() arg 2 must be a type" on every assignment to an alias-annotated var, aborting the event handler instead of at most logging a mismatch (0.9.9a1 pre-release FINDING-002). - Passing an event handler with an alias-annotated argument uncalled to an event trigger crashed page compile: typehint_issubclass() reached the bare issubclass() for a plain alias and failed the origin comparison for a subscripted one, escalating to a fatal error (FINDING-006). Resolve the alias at the entry of both functions, reusing resolve_type_alias(), which already handles parameterized aliases (Items[str]) and aliases nested in unions (Key | None). Alias-annotated vars now behave exactly like their resolved annotations at runtime. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EMjBXPozsNeQNSBZecNH8x
…ntime' into rel-fix-pep695-alias-runtime-perf-isinstance
Merging this PR will not alter performance
Performance Changes
Comparing 
Footnotes
|
6 tasks
Collaborator
|
seems like a better version of #6986 |
benedikt-bartscher
changed the title
Contributor
Greptile SummaryThis PR adds runtime support for PEP 695 aliases in type validation while reducing repeated work on validation and serialization hot paths.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issue identified. Alias resolution is applied before runtime type checks, the optimized origin checks preserve the prior helper semantics, and the deferred lookup caches retain the existing callable behavior.
|
| Filename | Overview |
|---|---|
| packages/reflex-base/src/reflex_base/utils/types.py | Adds alias resolution and memoized helper/import lookups without an identified correctness regression. |
| packages/reflex-base/src/reflex_base/utils/format.py | Caches the existing deferred serializer function while preserving caller-provided JSON defaults. |
| tests/units/reflex_base/utils/test_types.py | Covers bare, literal, generic, union-nested, native, and backported alias behavior. |
| tests/units/test_state.py | Verifies alias-annotated state assignments no longer crash or emit mismatch logs. |
| tests/benchmarks/test_isinstance.py | Adds representative scalar and nested-container benchmarks for the optimized validation paths. |
Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'upstream/c..." | Re-trigger Greptile
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is #6986 and #6862 merged together - just for a codspeed run.