Release reflex-release@0.1.0 - #6964
Merged
Merged
Conversation
* fix(reflex-release): stop a skipped build path from skipping the upload Exactly one of the built-in `build` job and a `[[tool.reflex-release.custom-build]]` job runs for a given package, so the other is always skipped. GitHub evaluates the implicit `success()` a job gets when its `if` names no status function over the whole transitive dependency closure rather than the direct `needs`, so that skipped build reached `publish` straight through the `collect` written to absorb it, and `tag-and-release` behind it: every build succeeded, the artifacts were verified and checksummed, and the upload silently never happened. Guard both jobs with an explicit `needs.<job>.result == 'success'`. Not `!failure()` as `collect` uses — a skipped `publish` is neither failed nor cancelled, so tolerating it would push the tag for a release that uploaded nothing. `release_from_changelog.yml`'s `report` job, the canonical failure signal for a partial release, was blind to the same shape: it accepted any skipped leg, so a batch that published nothing exited 0, and its "held back" diagnostic sat behind a flag that case never set. It now accepts a skipped leg only when detection found nothing for that leg to publish. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011bhWhmMrSDwsuUK41vXQ4T * test(reflex-release): run the report step with a POSIX bash `bash` on PATH on a Windows runner is the WSL launcher, which exits 1 with "Windows Subsystem for Linux has no installed distributions" — so the report cases expecting a red exit passed for the wrong reason and the green ones failed. Resolve Git for Windows' bash there instead (it ships beside the git the runners already have) and skip when no POSIX bash exists at all, so the worst case is a skip rather than a false failure. Inherit the environment rather than building a bare one, which bash on Windows needs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011bhWhmMrSDwsuUK41vXQ4T --------- Co-authored-by: Claude <noreply@anthropic.com>
masenf
approved these changes
Aug 28, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
masenf
pushed a commit
that referenced
this pull request
Aug 28, 2026
…-context-refactor-jv3pig Picks up #6964 (reflex-release 0.1.0), confined to packages/reflex-release. Clean auto-merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Materialized changelogs for release action
release-from-prerelease(dispatched onr/pre-2026.08.13).reflex-release0.1.0a40.1.0reflex-release-v0.1.0Merging this PR lands the versions above for release: the push to
maintriggers the
release_from_changelog.ymlworkflow, which builds each package andthen waits for
pypienvironment approval before uploading; the tag andGitHub release are created only after a successful upload. If a publish
fails, fix the problem on top of the changelog bump — the next push retries
automatically.