fix(app): allow static segments as siblings of dynamic route segments - #6953
Merged
masenf merged 4 commits intoAug 27, 2026
Merged
Conversation
_find_route_conflict flagged a conflict whenever an existing route's dynamic segment lined up with a different static segment of a new bracket-containing route (e.g. /posts/[id] vs /posts/all/[x]), and only in that registration order. React Router resolves such siblings fine (static wins), so only two dynamic segments with different names at the same position are a real conflict.
Contributor
Greptile SummaryThis PR refines route-conflict detection so static route segments can coexist with dynamic siblings while differently named dynamic segments at the same position remain conflicts.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| reflex/app.py | Updates route-conflict detection to permit static and dynamic siblings while retaining rejection of differently named dynamic peers. |
| tests/units/test_route.py | Adds bidirectional regression cases covering static segments alongside dynamic route segments. |
| news/+static-dynamic-route-conflict.bugfix.md | Documents the corrected route-registration behavior and its former order dependence. |
Reviews (4): Last reviewed commit: "Merge remote-tracking branch 'upstream/m..." | Re-trigger Greptile
Merging this PR will not alter performance
Comparing Footnotes
|
benedikt-bartscher
marked this pull request as ready for review
August 27, 2026 08:09
masenf
approved these changes
Aug 27, 2026
masenf
pushed a commit
that referenced
this pull request
Aug 28, 2026
Sample apps, Playwright drivers, NOTES.md and evidence screenshots from end-to-end browser testing of the routing fixes (#6593 on_load supersedes, #6790 splat matching, #6953 static/dynamic siblings, #6919 chained-event routing) and the rx.memo changes (#6949 call-site auto-memoization, #6605 RestProp style classification, #6945 displayName, #6730 wrapper=). Both clusters pass in dev and prod against the published PyPI alphas, with 0.9.8 baseline comparisons reproducing the old bugs. Anomalies recorded in each NOTES.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EMjBXPozsNeQNSBZecNH8x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_find_route_conflict flagged a conflict whenever an existing route's dynamic segment lined up with a different static segment of a new bracket-containing route (e.g. /posts/[id] vs /posts/all/[x]), and only in that registration order. React Router resolves such siblings fine (static wins), so only two dynamic segments with different names at the same position are a real conflict.