Remove accidental whitelist changes#6524
Conversation
Leave the commented out code so it's easy to just compile the getting started page for testing purposes.
Greptile SummaryThis PR reverts two accidental entries (
Confidence Score: 4/5Safe to merge — the only functional change is removing two stale whitelist entries, returning the list to an empty (build-all) state. The commented-out line is cosmetic. The revert itself is correct and low-risk. The one open question is whether the deliberately committed comment aligns with team practice; otherwise the change is straightforward. docs/app/reflex_docs/whitelist.py — contains a commented-out entry that may warrant cleanup per team convention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Request for page path] --> B{WHITELISTED_PAGES empty?}
B -- Yes --> C[Build all pages ✓]
B -- No --> D{path == /}
D -- Yes --> E[Always build root ✓]
D -- No --> F{Only entry is /}
F -- Yes --> G[Skip page ✗]
F -- No --> H{path.startswith any whitelisted?}
H -- Yes --> I[Build page ✓]
H -- No --> J[Skip page ✗]
Reviews (1): Last reviewed commit: "Remove accidental whitelist changes" | Re-trigger Greptile |
| "/getting-started/introduction", | ||
| "/library/forms/select", | ||
| "/library/forms/form", | ||
| # "/getting-started/introduction", |
There was a problem hiding this comment.
Commented-out code left in production file
The team's rule requires removing commented-out code before merging. The PR description acknowledges this is intentional for local testing convenience, but the commented-out entry # "/getting-started/introduction" will persist in the main branch and can cause confusion about whether this page is intentionally excluded or accidentally left commented out. Consider removing the comment and relying on the module docstring (which already includes this path as an example) to remind developers how to re-enable a page for testing.
Rule Used: Remove commented-out code before merging PRs. (source)
Learned From
reflex-dev/reflex-web#1619
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Leave the commented out code so it's easy to just compile the getting started page for testing purposes.