The system become extremely slow when loading a huge Java workspace #1236

Activity

1. Eskibear commented on Jan 15, 2020

   

   Eskibear

   on Jan 15, 2020

   Contributor

   More actions

   @Nukepayload2 Are you opening a single folder containing 40+ Java projects, or a workspace containing 40+ root folder (e.g. via Add Folder to Workspace...)?

   For the latter, I guess it might be related to https://github.com/redhat-developer/vscode-java/pull/1201/files#diff-45327f86d4438556066de133327f4ca2R863

   For each workspace folder, it searches the whole workspace for *.java files. And below is what the API author suggests to do:

   Use a RelativePattern to restrict the search results to a workspace folder
2. Nukepayload2 commented on Jan 16, 2020

   

   Nukepayload2

   on Jan 16, 2020

   Author

   More actions

   @Eskibear I'm opening a workspace that containing 40+ root folders. What should I do now? Wait for fix or edit a configuration file?
3. Eskibear commented on Jan 17, 2020

   

   Eskibear

   on Jan 17, 2020

   Last edited by Eskibear

   Contributor

   More actions

   I tried limiting the search scope to current workspace root, and did a simple test with a workspace containing 6 projects, and it turned out to be a big performance boost.

   Before

   workspace.findFiles("*.java", undefined, 1);
workspace.findFiles("{src, test}/**/*.java", undefined, 1);

   spring-petclinic, *.java: 1737ms
   spring-boot-deployment-test-wlp, *.java: 1736ms
   spring-boot-deployment-test-wildfly, *.java: 1737ms
   spring-boot-deployment-test-glassfish, *.java: 1738ms
   spring-boot-deployment-test-tomcat, *.java: 1738ms
   spring-boot-deployment-test-tomee, *.java: 1738ms
   
   spring-petclinic, {src,test}/**/*.java: 1872ms
   spring-boot-deployment-test-wlp, {src,test}/**/*.java: 1872ms
   spring-boot-deployment-test-glassfish, {src,test}/**/*.java: 1871ms
   spring-boot-deployment-test-tomcat, {src,test}/**/*.java: 1872ms
   spring-boot-deployment-test-wildfly, {src,test}/**/*.java: 1872ms
   spring-boot-deployment-test-tomee, {src,test}/**/*.java: 1871ms
   

   After limiting search scope with a RelativePattern

   workspace.findFiles(new RelativePattern(rootFolder, "*.java"), undefined, 1);
workspace.findFiles(new RelativePattern(rootFolder, "{src, test}/**/*.java"), undefined, 1);

   spring-petclinic, *.java: 912ms
   spring-boot-deployment-test-wlp, *.java: 910ms
   spring-boot-deployment-test-wildfly, *.java: 911ms
   spring-boot-deployment-test-glassfish, *.java: 911ms
   spring-boot-deployment-test-tomcat, *.java: 912ms
   spring-boot-deployment-test-tomee, *.java: 911ms
   
   spring-petclinic, {src,test}/**/*.java: 223ms
   spring-boot-deployment-test-wlp, {src,test}/**/*.java: 214ms
   spring-boot-deployment-test-wildfly, {src,test}/**/*.java: 522ms
   spring-boot-deployment-test-glassfish, {src,test}/**/*.java: 223ms
   spring-boot-deployment-test-tomcat, {src,test}/**/*.java: 522ms
   spring-boot-deployment-test-tomee, {src,test}/**/*.java: 522ms
   
   
4. fbricon

   closed this as completedin #1245on Jan 20, 2020
5. Bhawika16 commented on May 17, 2024

   

   Bhawika16

   on May 17, 2024

   More actions

   Where we have to do this change? @Eskibear @Nukepayload2 @gbraad . Can you please tell