Repository navigation
Pause/resume on request not working #84
Description
Hi,
Why do we have this code in Server class?
$request->on('pause', function () use ($conn) {
$conn->emit('pause');
});
$request->on('resume', function () use ($conn) {
$conn->emit('resume');
});
I have changed emit's to correct methods (pause/resume), like this:
$request->on('pause', function () use ($conn) {
$conn->pause();
});
$request->on('resume', function () use ($conn) {
$conn->resume();
});
And now pausing works.
Activity
clue commentedon Nov 22, 2016
Thanks for reporting! Do you feel like filing a PR and adding some tests to verify this? Thanks! 👍
nick4fake commentedon Nov 22, 2016
@clue Ok, will do that tomorrow
Fixes reactphp#84 issue: pause/resume on request not working
nick4fake commentedon Nov 29, 2016
@clue sorry for delaying the fix. Created pull review.
Is there any roadmap for merging all those pull request? There are 25 PRs now.