Repository navigation
remoteAddress property not part of PSR-7 #153
Description
Hi,
Just a quick thought about remoteAddress property which is added to every request object. Shouldn't we add it through withAttribute method? This will be compatible with PSR7, right now it doesn't look that way https://github.com/reactphp/http/blob/master/src/Server.php#L235
Activity
clue commentedon Mar 30, 2017
Thanks for spotting and reporting this @maciejmrozinski!
This is something we're aware of and I hear this is something @legionth is currently working on as part of #28 :-) Note that this isn't "incompatible" per se, it's just not part of PSR7 and the server params or attributes would be better suited for this 👍
Refs #146, so this only affects the current master branch and has not (and will not) end up in any releases.
maciejmrozinski commentedon Mar 30, 2017
@clue You're right. "Incompatible" is too strong word for this situation. Waiting to see it changed by @legionth then :) thx
[-]remoteAddress property incompatible with PSR7[/-][+]remoteAddress property not part of PSR-7[/+]ssipos90 commentedon Apr 2, 2017
@maciejmrozinski, that class can implement and extend anything, as long as it respects the psr interface.
maciejmrozinski commentedon Apr 7, 2017
Resolved in #160 :)