Repository navigation
docs(curators): bring both documents up to today's work - #240
Merged
Merged
Conversation
`CURATOR-REPORT.md` said the keyboard-reachable controls were "Species and Interactors". That label went back to **Overlay** today (#228) -- it and its position were decided at EBI -- so the document was describing a control that no longer exists under that name. It also claimed 635 shapes come out of R-HSA-109606's PowerPoint export. Re-measured today: **974**, counted from `ppt/slides/slide1.xml`, with zero pictures and no embedded media. The claim the curators were testing -- that it is shapes rather than one picture -- holds; the figure was stale (#167). Added, all of them things a curator will meet: - the count beside each resource now follows the pathway on screen, and why the old numbers were plausible rather than obviously wrong - a selection survives opening a pathway from inside the diagram; the flag was never the problem - illustration downloads work again, **with the caveat that the fix is a cache on this machine** -- so an illustration that still fails is a gap in what is cached, not a fault in the site (#230) - Perturb offers something: its catalogue was never wired up here, so the button appeared and did nothing. Eleven pathways now - if you leave the email box empty when asking for analysis reports, the reports are still made and no mail is sent, with nothing saying so (#238, #168) `RELEASE-TESTING.md` gains the two rows today's fixes are covered by, including why the count is a unit test: a browser test of it passed with and without the fix, which is worse than no test. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
I wrote that Perturb now offers something, having wired up DeltaSignal's
catalogue on this box. Checked it against beta rather than against the box:
buttons offered on beta.reactome.org/PathwayBrowser/R-HSA-69620:
["query_stats Analyze"]
No Perturb. `deltaSignal: true` is set on the **development** profile only, and
the comment beside it says why -- `proxy.conf.js` routes /api to a dev-server
proxy that does not exist in a built artifact, so enabling it elsewhere would
offer a button whose every call fails. Beta serves a production-shaped build.
So the catalogue work is real and the endpoint answers, but a curator will not see
any of it. A paragraph telling them to look would have sent them hunting for a
button that is not there.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both documents were last touched on 16 September and today changed enough to make
parts of them wrong.
Two corrections
The label.
CURATOR-REPORT.mddescribed "the Species and Interactorscontrols". That label went back to Overlay today (#228) — it and its position
were decided at EBI — so the document named a control that no longer exists under
that name.
A stale figure. It claimed 635 shapes come out of R-HSA-109606's
PowerPoint export. Re-measured from
ppt/slides/slide1.xmltoday: 974, withzero
<p:pic>and no embedded media. The claim the curators were actually testing— shapes rather than one picture — holds; the number did not (#167).
Added, all things a curator will meet
the old numbers were plausible rather than obviously wrong, which is why it is
worth a look rather than a glance.
never the problem; that always survived.
cache on this machine, so an illustration that still fails is a gap in what is
cached rather than a fault in the site (The diagram exporter 404s on the dev box: download/current/diagram was deleted #230).
button appeared and did nothing. Eleven pathways now, and the panel being absent
elsewhere is expected.
still made. We do not enforce the address (The GSA form never enforces a required parameter, including the email address #238) and the sending happens on a
server we do not control (Curator reports still open: flag lost on navigation, and reports not emailed #168), so the practical advice is to check the box
before submitting.
Testing document
Two rows for today's fixes, including why the resource count is covered by a
unit test: a browser test of it passed with and without the fix, which is
worse than no test.
🤖 Generated with Claude Code