Repository navigation
fix(interactors): keep the overlay when the reader comes back (#201) - #207
Merged
Merged
Conversation
Going back to a pathway lost the interactor overlay, which is the sharp case in #201: forward navigation already carried `?overlay=…`, and returning to the pathway where it was chosen threw it away. The cause was not the URL. `stateToDiagram` replays the address through the same call a reader's click goes through, and `currentResource()` still held the resource from before the navigation while the rebuilt diagram held no badges -- so the replay was read as the toggle-to-unselect gesture, "the reader clicked the resource that is already active", and put it away. Measured on beta by logging every history write: back x1 -> ?tab=details replace ?overlay=IntAct&tab=details push ?tab=details The browser restored the overlay and the app immediately pushed a URL without it, adding a history entry as it went. So the replay says it is a replay. A reader's gesture and the address being honoured are different things, and this method is reached by both -- the same shape of fault as a shared confidence threshold being reset, found in the same place a week ago. Asserted on badges drawn rather than on the address: a URL that keeps the parameter while the diagram shows nothing fails the reader identically. Shown red against the old behaviour -- 9 badges expected, 0 drawn. Also corrected here: the issue says the resource "is not in the URL". It is, and a link carrying it opens with the overlay drawn -- verified. Only Back was broken. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #201.
Going back to a pathway lost the interactor overlay — the sharp case in that
report. Forward navigation already carried
?overlay=…; returning to thepathway where it was chosen threw it away.
The cause was not the URL
stateToDiagramreplays the address through the same call a reader's clickgoes through, and
currentResource()still held the resource from before thenavigation while the rebuilt diagram held no badges. So the replay was read as
the toggle-to-unselect gesture — "the reader clicked the resource that is already
active" — and put it away.
Measured on beta by logging every history write:
The browser restored the overlay and the app immediately pushed a URL without it,
adding a history entry on the way.
?tab=details?overlay=IntActThe fix
The replay says it is a replay. A reader's gesture and the address being honoured
are different things, and this method is reached by both — the same shape of
fault as a shared confidence threshold being reset, found in the same place last
week.
Corrections to the issue
The report says the resource "is not in the URL" and that a link cannot carry it.
That is no longer true:
?overlay=IntActopens with the overlay drawn, verified.Only Back was broken.
Verification
Asserted on badges drawn, not on the address — a URL that keeps the parameter
while the diagram shows nothing fails the reader identically. Shown red against
the old behaviour: 9 expected, 0 drawn.
240 unit tests, lint 652 and dead code 145 unchanged from baseline.
🤖 Generated with Claude Code