You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Small follow-ups: a dead null check in the URL state, and workflow time limits #954
Small follow-ups found while fixing the legacy query parameters (spec 025 T001a), in projects/pathway-browser/src/app/services/router-url-state.service.ts:
A line that never runs.if (value === undefined || value === null) param.set(value); runs only if the router hands a query parameter as null or undefined, and it never does. If it ever ran, the code would carry on into the branch below and throw on value.split or value.replaceAll. It should return early, or go.
From the CI review (#946): the deploy, guardrail and library-update workflows have no timeout-minutes. Deploy needs thought before a limit is added, because cutting a deploy off partway is its own risk.
Activity