Skip to content

Small follow-ups: a dead null check in the URL state, and workflow time limits #954

Open

Description

@adamjohnwright

Small follow-ups found while fixing the legacy query parameters (spec 025 T001a), in projects/pathway-browser/src/app/services/router-url-state.service.ts:

  • A line that never runs. if (value === undefined || value === null) param.set(value); runs only if the router hands a query parameter as null or undefined, and it never does. If it ever ran, the code would carry on into the branch below and throw on value.split or value.replaceAll. It should return early, or go.

From the CI review (#946): the deploy, guardrail and library-update workflows have no timeout-minutes. Deploy needs thought before a limit is added, because cutting a deploy off partway is its own risk.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions