Updates keyboard handling to use keyCode#1
Merged
Conversation
Contributor
|
oh woops, I was screwing around with |
ryanflorence
added a commit
that referenced
this pull request
Sep 29, 2014
Updates keyboard handling to use keyCode
diasbruno
pushed a commit
to diasbruno/react-modal
that referenced
this pull request
Jun 16, 2017
Fix compilation.
diasbruno
added a commit
to diasbruno/react-modal
that referenced
this pull request
Jun 20, 2017
…eactjs#1) It seems that the using redux, we can get a async update in which can fail when trying to focus the content of the modal. This should be a temporary fix since the issue is hard to reproduce, but safe for other applications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was either change the code to strings, or compare on
keyCode... The latter makes more sense to me.