Repository navigation
Conversation
|
Hi @arntanguy! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
intergalacticspacehighway
left a comment
There was a problem hiding this comment.
Thanks for upstreaming this! Two small requests:
- Could we name it
YOGA_USE_SYSTEM_GTEST? googletest is the only thing we fetch, so a name that says what it does reads clearer thanYOGA_DISABLE_FETCHCONTENT. - Could the
option()move totests/CMakeLists.txt, next to where it's used? Ourunit_testsscript configurestests/directly.
wdyt?
Withdrawn, see comment below.
|
Actually, CMake already supports this without a new option: |
|
Using
In short, 493490f has the requested naming updates. The choice is yours. |
|
Btw, I also had to build with that is with I can open an issue if you wish. |
This PR allows packager (e.g
Nix) to provide their own version ofgoogle-test. To not risk disturbing existing user's workflows, this is gated behing the newYOGA_DISABLE_FETCHCONTENToption, with defaultOFF.