Skip to content

Update 14-communicate-between-components.md for grammatical changes#2760

Merged
zpao merged 1 commit into
react:masterfrom
alextsg:patch-3
Dec 22, 2014
Merged

Update 14-communicate-between-components.md for grammatical changes#2760
zpao merged 1 commit into
react:masterfrom
alextsg:patch-3

Conversation

@alextsg

@alextsg alextsg commented Dec 21, 2014

Copy link
Copy Markdown
Contributor

Update to improve grammatical parallelism, as expressions separated by commas should share similar form.

BEFORE: Subscribe to events in componentDidMount(), unsubscribe in componentWillUnmount(), and when you receive an event, call setState().
AFTER: Subscribe to events in componentDidMount(), unsubscribe in componentWillUnmount(), and call setState() when you receive an event.

@zpao

zpao commented Dec 22, 2014

Copy link
Copy Markdown
Contributor

👍

zpao added a commit that referenced this pull request Dec 22, 2014
Update 14-communicate-between-components.md for grammatical changes
@zpao zpao merged commit 343cda7 into react:master Dec 22, 2014
zpao added a commit that referenced this pull request Jan 17, 2015
Update 14-communicate-between-components.md for grammatical changes
zpao added a commit that referenced this pull request Jan 17, 2015
dilberx pushed a commit to dilberx/react that referenced this pull request Apr 15, 2026
Update 14-communicate-between-components.md for grammatical changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants