Repository navigation
Subtract min from the accessibilityValue percentage on iOS - #60016
Open
faciledictu wants to merge 1 commit into
Open
faciledictu wants to merge 1 commit into
faciledictu wants to merge 1 commit into
Conversation
Visual regressionNo visual differences at android: no capture |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #60015.
On iOS the value of a view with
accessibilityValue={{ min, max, now }}wasnow / (max - min):{ min: 10, max: 20, now: 15 }was read as "150%", andmin == maxgave "+∞".It is now
(now - min) / (max - min). There is no value when the range is empty ornowis outside it, the same condition as on Android and in the old architecture.Changelog:
[IOS] [FIXED] - The
accessibilityValuepercentage takesmininto accountTest Plan:
Added tests to
RCTViewComponentViewTests; they fail without this change and pass with it. Checked on iOS with https://github.com/faciledictu/rn-a11y-value-percentage-repro: V2 is "50%", V3 "0%", and V5, V6 and V7 have no value.