Skip to content

Add LICENSE file to all published packages - #60010

Open
huntie wants to merge 1 commit into
mainfrom
pr60010
Open

huntie wants to merge 1 commit into
mainfrom
pr60010

Conversation

@huntie

@huntie huntie commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Only react-native ships a LICENSE file to npm. The other @react-native/* packages publish without one (e.g. @react-native/dev-middleware@0.88.1), since npm publish runs from each package directory and never sees the repo root LICENSE.

Changes

  • Add a copy of the root LICENSE to each package — 22 packages. npm always includes a root LICENSE, so no files changes are needed.
  • Switch debugger-frontend from BSD-3-Clause to MIT, matching every other package. The bundled devtools-frontend build keeps its BSD notice in dist/third-party/LICENSE.
  • Extend check-packages-test to require a LICENSE in every published package, and for MIT packages, one matching the root LICENSE.

Committed copies over symlinks or a prepack copy: npm 7+ drops symlinked files from tarballs, and only some packages run prepack.

Changelog:
[General][Fixed] - Include LICENSE file in all published @react-native/* packages

Test Plan

yarn jest scripts/monorepo-tests/__tests__/check-packages-test.js

✅ 6 of 6 tests pass. Deleting packages/dev-middleware/LICENSE and editing packages/polyfills/LICENSE fail the new test with missing LICENSE and LICENSE does not match the root LICENSE.

npm pack --dry-run --ignore-scripts  # in packages/dev-middleware, debugger-frontend, react-native

✅ Each tarball lists LICENSE at its root. debugger-frontend also keeps dist/third-party/LICENSE.

✅ ESLint and Prettier pass on the changed test, and yarn flow-check reports no errors in it.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 15, 2026
@huntie
huntie requested a review from cortinico November 15, 2026 14:08
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 15, 2026
@github-actions

Copy link
Copy Markdown

Visual regression

1 visual difference(s) at e7ea7ceda992. Visual differences need maintainer approval. Review the report, then apply visual-change-approved.

ios button/default-styling/default: Changed, 2492802 px (100.000%)

diff

Expected and Captured
Expected Captured
expected captured

@huntie
huntie enabled auto-merge (squash) November 15, 2026 16:59
"url": "git+https://github.com/react/react-native.git",
"directory": "packages/debugger-frontend"
},
"license": "BSD-3-Clause",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one needs some care - BSD3 is Chromium's licence and so debugger-frontend (largely a CDT fork) has to respect it.

@robhogan
robhogan disabled auto-merge November 15, 2026 23:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants