Skip to content

Delete dead sourceURLForBridge delegate chain (#59452) - #59452

Merged
meta-codesync[bot] merged 1 commit into
react:mainfrom
christophpurrer:export-D127294778
Oct 27, 2026
Merged

meta-codesync[bot] merged 1 commit into
react:mainfrom
christophpurrer:export-D127294778

Conversation

@christophpurrer

@christophpurrer christophpurrer commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

sourceURLForBridge: has no callers: the factory reads bundleURL directly, and the default delegate's implementations only threw or forwarded to each other. Delete the protocol method with those implementations and the factory's dead configuration assignment. The RCTJavaScriptLoader.h import stays: removing it breaks every RCTBridge.h importer that uses the loader types.

Changelog:
[iOS][Removed] - Remove deprecated RCTBridgeDelegate sourceURLForBridge:

Reviewed By: javache

Differential Revision: D127294778

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2026
@meta-codesync

meta-codesync Bot commented Oct 24, 2026

Copy link
Copy Markdown

@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127294778.

Summary:

`sourceURLForBridge:` has no callers: the factory reads `bundleURL` directly, and the default delegate's implementations only threw or forwarded to each other. Delete the protocol method with those implementations and the factory's dead configuration assignment. The `RCTJavaScriptLoader.h` import stays: removing it breaks every `RCTBridge.h` importer that uses the loader types.

Changelog:
[iOS][Removed] - Remove deprecated `RCTBridgeDelegate` `sourceURLForBridge:`

Reviewed By: javache

Differential Revision: D127294778
@meta-codesync meta-codesync Bot changed the title Delete dead sourceURLForBridge delegate chain Delete dead sourceURLForBridge delegate chain (#59452) Oct 27, 2026
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 27, 2026
Summary:

`sourceURLForBridge:` has no callers: the factory reads `bundleURL` directly, and the default delegate's implementations only threw or forwarded to each other. Delete the protocol method with those implementations and the factory's dead configuration assignment. The `RCTJavaScriptLoader.h` import stays: removing it breaks every `RCTBridge.h` importer that uses the loader types.

Changelog:
[iOS][Removed] - Remove deprecated `RCTBridgeDelegate` `sourceURLForBridge:`

Reviewed By: javache

Differential Revision: D127294778
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 27, 2026
Summary:

`sourceURLForBridge:` has no callers: the factory reads `bundleURL` directly, and the default delegate's implementations only threw or forwarded to each other. Delete the protocol method with those implementations and the factory's dead configuration assignment. The `RCTJavaScriptLoader.h` import stays: removing it breaks every `RCTBridge.h` importer that uses the loader types.

Changelog:
[iOS][Removed] - Remove deprecated `RCTBridgeDelegate` `sourceURLForBridge:`

Reviewed By: javache

Differential Revision: D127294778
@meta-codesync
meta-codesync Bot merged commit 34795cb into react:main Oct 27, 2026
95 of 97 checks passed
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @christophpurrer in 34795cb

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 27, 2026
vonovak added a commit to expo/expo that referenced this pull request Nov 2, 2026
… settings (#52763)

# Why

React Native removed the bridge delegate hook in
[react-native#59452](react/react-native#59452).
Unused test helpers and an obsolete dev-client AppDelegate still
reference that API. The runner also advertises iOS delegate settings
that it never reads.

# How

Delete the unused bridge helpers from dev-menu and dev-launcher. Delete
the unused dev-client AppDelegate fixture, its ignored runner setting,
and the unused `ios.appDelegate` and `ios.appDelegateHeader` fields from
`expo-test-runner`. Typed consumers must remove those settings. The
runner still generates the compiled AppDelegate from the bare template.
Runtime behavior does not change. Add a patch changeset for
`expo-test-runner`.

This is PR 1 of 8.

**[1. Test code and runner
settings](#52763 → [2. iOS
apps](#52764) → [3. Bare
template](#52765) → [4. Brownfield
template](#52766) → [5. Updates
example](#52767) → [6. Installer
migration](#52771) → [7. Current
docs](#52768) → [8. macOS
app](#52769)

# Test Plan

- `et check-packages expo-test-runner` passed on the combined branch.
- Executed `getTemplateFiles()` for both dev-client configurations.
Neither maps an AppDelegate override.
- The full Detox suite was not rerun for this regrouping.

# Screenshots

No UI change.

# Checklist

- [x] Added a short patch changeset for `expo-test-runner`.
- [x] No config plugin implementation changed.
- [x] Followed the documentation writing style where applicable.
vonovak added a commit to expo/expo that referenced this pull request Nov 2, 2026
# Why

Current app delegates override `sourceURL(for:)`, which React Native
removed in
[react-native#59452](react/react-native#59452).
Those overrides fail to compile against the affected React Native
nightly.

# How

Remove the forwarding overrides

# Test Plan

- green CI

# Screenshots

No UI change.

# Checklist

- [x] No changeset needed for this test, example, documentation, or
repository app change.
- [x] No config plugin implementation changed.
- [x] Followed the documentation writing style where applicable.
vonovak added a commit to expo/expo that referenced this pull request Nov 2, 2026
…52765)

# Why

The bare template emits a `sourceURL(for:)` override. Generated apps
fail to compile after
[react-native#59452](react/react-native#59452)
removes that superclass method.

# How

Remove the redundant forwarding method and keep `bundleURL()`.

# Test Plan

- green CI
- Native generated-app release builds

# Screenshots

No UI change.

# Checklist

- [x] Added a changeset.
- [ ] Validate generated apps with `npx expo prebuild` and EAS Build
before marking ready.
- [x] Followed the documentation writing style where applicable.
vonovak added a commit to expo/expo that referenced this pull request Nov 2, 2026
# Why

The generated brownfield delegate overrides a bridge hook removed by
React Native react/react-native#59452. Those
overrides fail to compile against the affected React Native nightly.

# How

Remove the forwarding `sourceURL(for:)` override from the Swift
template.



# Test Plan

- green CI

# Screenshots

No UI change.

# Checklist

- [x] Added a changeset.
- [ ] Validate generated apps with `npx expo prebuild` and EAS Build
before marking ready.
- [x] Followed the documentation writing style where applicable.
vonovak added a commit to expo/expo that referenced this pull request Nov 2, 2026
)

# Why

The custom initialization fixture contains an obsolete bridge delegate
override react/react-native#59452. The
`launchAssetUrl()` API comment also directs callers to that removed
hook.

# How

Remove the fixture override and update the API comment to name
`bundleURL()`.

# Test Plan

- green CI

# Screenshots

No UI change.

# Checklist

- [x] No changeset needed for this test, example, documentation, or
repository app change.
- [x] No config plugin implementation changed.
- [x] Followed the documentation writing style where applicable.
t0maboro added a commit to software-mansion/react-native-screens that referenced this pull request Nov 9, 2026
## Description

RN 0.89 brings synchronous shadow state updates on Android.

<img width="220" height="165" alt="asdf"
src="https://github.com/user-attachments/assets/fdcf081c-0e01-4aa0-9223-7cb6344ec7fc"
/>

This version also seems to be preparing to make SPM the default:
react-native-community/cli#2881

Follow-up: `react-native-restart` doesn't support SPM; maybe we need to
consider creating our own TM and decoupling.

## Changes

- applied helper
https://react-native-community.github.io/upgrade-helper/?from=0.88.0&to=0.89.0-rc.0
- removed sourceURLForBridge override
react/react-native#59452
- bumped RNGH & RNSAC to versions supporting SPM

## Before & after - visual documentation

N/A

## Test plan

- [x] Android Debug
- [x] Android Release
- [x] iOS Debug
- [x] iOS Release
- [ ] SPM - deferred to follow-up because of react-native-restart
decoupling

## Checklist

- [ ] Included code example that can be used to test this change.
- [ ] For visual changes, included screenshots / GIFs / recordings
documenting the change.
- [ ] For API changes, updated relevant public types.
- [ ] Ensured that CI passes
usama-liaqat pushed a commit to usama-liaqat/react-native that referenced this pull request Nov 14, 2026
Summary:

`sourceURLForBridge:` has no callers: the factory reads `bundleURL` directly, and the default delegate's implementations only threw or forwarded to each other. Delete the protocol method with those implementations and the factory's dead configuration assignment. The `RCTJavaScriptLoader.h` import stays: removing it breaks every `RCTBridge.h` importer that uses the loader types.

Changelog:
[iOS][Removed] - Remove deprecated `RCTBridgeDelegate` `sourceURLForBridge:`

Reviewed By: javache

Differential Revision: D127294778

Pull Request resolved: react#59452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants