Repository navigation
Delete dead sourceURLForBridge delegate chain (#59452) - #59452
Merged
Merged
Conversation
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127294778. |
Summary: `sourceURLForBridge:` has no callers: the factory reads `bundleURL` directly, and the default delegate's implementations only threw or forwarded to each other. Delete the protocol method with those implementations and the factory's dead configuration assignment. The `RCTJavaScriptLoader.h` import stays: removing it breaks every `RCTBridge.h` importer that uses the loader types. Changelog: [iOS][Removed] - Remove deprecated `RCTBridgeDelegate` `sourceURLForBridge:` Reviewed By: javache Differential Revision: D127294778
christophpurrer
force-pushed
the
export-D127294778
branch
from
October 27, 2026 14:14
30c84e9 to
fb652e7
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: `sourceURLForBridge:` has no callers: the factory reads `bundleURL` directly, and the default delegate's implementations only threw or forwarded to each other. Delete the protocol method with those implementations and the factory's dead configuration assignment. The `RCTJavaScriptLoader.h` import stays: removing it breaks every `RCTBridge.h` importer that uses the loader types. Changelog: [iOS][Removed] - Remove deprecated `RCTBridgeDelegate` `sourceURLForBridge:` Reviewed By: javache Differential Revision: D127294778
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
Summary: `sourceURLForBridge:` has no callers: the factory reads `bundleURL` directly, and the default delegate's implementations only threw or forwarded to each other. Delete the protocol method with those implementations and the factory's dead configuration assignment. The `RCTJavaScriptLoader.h` import stays: removing it breaks every `RCTBridge.h` importer that uses the loader types. Changelog: [iOS][Removed] - Remove deprecated `RCTBridgeDelegate` `sourceURLForBridge:` Reviewed By: javache Differential Revision: D127294778
Collaborator
|
This pull request was successfully merged by @christophpurrer in 34795cb When will my fix make it into a release? | How to file a pick request? |
This was referenced Nov 2, 2026
Merged
vonovak
added a commit
to expo/expo
that referenced
this pull request
Nov 2, 2026
… settings (#52763) # Why React Native removed the bridge delegate hook in [react-native#59452](react/react-native#59452). Unused test helpers and an obsolete dev-client AppDelegate still reference that API. The runner also advertises iOS delegate settings that it never reads. # How Delete the unused bridge helpers from dev-menu and dev-launcher. Delete the unused dev-client AppDelegate fixture, its ignored runner setting, and the unused `ios.appDelegate` and `ios.appDelegateHeader` fields from `expo-test-runner`. Typed consumers must remove those settings. The runner still generates the compiled AppDelegate from the bare template. Runtime behavior does not change. Add a patch changeset for `expo-test-runner`. This is PR 1 of 8. **[1. Test code and runner settings](#52763 → [2. iOS apps](#52764) → [3. Bare template](#52765) → [4. Brownfield template](#52766) → [5. Updates example](#52767) → [6. Installer migration](#52771) → [7. Current docs](#52768) → [8. macOS app](#52769) # Test Plan - `et check-packages expo-test-runner` passed on the combined branch. - Executed `getTemplateFiles()` for both dev-client configurations. Neither maps an AppDelegate override. - The full Detox suite was not rerun for this regrouping. # Screenshots No UI change. # Checklist - [x] Added a short patch changeset for `expo-test-runner`. - [x] No config plugin implementation changed. - [x] Followed the documentation writing style where applicable.
vonovak
added a commit
to expo/expo
that referenced
this pull request
Nov 2, 2026
# Why Current app delegates override `sourceURL(for:)`, which React Native removed in [react-native#59452](react/react-native#59452). Those overrides fail to compile against the affected React Native nightly. # How Remove the forwarding overrides # Test Plan - green CI # Screenshots No UI change. # Checklist - [x] No changeset needed for this test, example, documentation, or repository app change. - [x] No config plugin implementation changed. - [x] Followed the documentation writing style where applicable.
vonovak
added a commit
to expo/expo
that referenced
this pull request
Nov 2, 2026
…52765) # Why The bare template emits a `sourceURL(for:)` override. Generated apps fail to compile after [react-native#59452](react/react-native#59452) removes that superclass method. # How Remove the redundant forwarding method and keep `bundleURL()`. # Test Plan - green CI - Native generated-app release builds # Screenshots No UI change. # Checklist - [x] Added a changeset. - [ ] Validate generated apps with `npx expo prebuild` and EAS Build before marking ready. - [x] Followed the documentation writing style where applicable.
vonovak
added a commit
to expo/expo
that referenced
this pull request
Nov 2, 2026
# Why The generated brownfield delegate overrides a bridge hook removed by React Native react/react-native#59452. Those overrides fail to compile against the affected React Native nightly. # How Remove the forwarding `sourceURL(for:)` override from the Swift template. # Test Plan - green CI # Screenshots No UI change. # Checklist - [x] Added a changeset. - [ ] Validate generated apps with `npx expo prebuild` and EAS Build before marking ready. - [x] Followed the documentation writing style where applicable.
vonovak
added a commit
to expo/expo
that referenced
this pull request
Nov 2, 2026
) # Why The custom initialization fixture contains an obsolete bridge delegate override react/react-native#59452. The `launchAssetUrl()` API comment also directs callers to that removed hook. # How Remove the fixture override and update the API comment to name `bundleURL()`. # Test Plan - green CI # Screenshots No UI change. # Checklist - [x] No changeset needed for this test, example, documentation, or repository app change. - [x] No config plugin implementation changed. - [x] Followed the documentation writing style where applicable.
4 of 9 tasks
t0maboro
added a commit
to software-mansion/react-native-screens
that referenced
this pull request
Nov 9, 2026
## Description RN 0.89 brings synchronous shadow state updates on Android. <img width="220" height="165" alt="asdf" src="https://github.com/user-attachments/assets/fdcf081c-0e01-4aa0-9223-7cb6344ec7fc" /> This version also seems to be preparing to make SPM the default: react-native-community/cli#2881 Follow-up: `react-native-restart` doesn't support SPM; maybe we need to consider creating our own TM and decoupling. ## Changes - applied helper https://react-native-community.github.io/upgrade-helper/?from=0.88.0&to=0.89.0-rc.0 - removed sourceURLForBridge override react/react-native#59452 - bumped RNGH & RNSAC to versions supporting SPM ## Before & after - visual documentation N/A ## Test plan - [x] Android Debug - [x] Android Release - [x] iOS Debug - [x] iOS Release - [ ] SPM - deferred to follow-up because of react-native-restart decoupling ## Checklist - [ ] Included code example that can be used to test this change. - [ ] For visual changes, included screenshots / GIFs / recordings documenting the change. - [ ] For API changes, updated relevant public types. - [ ] Ensured that CI passes
usama-liaqat
pushed a commit
to usama-liaqat/react-native
that referenced
this pull request
Nov 14, 2026
Summary: `sourceURLForBridge:` has no callers: the factory reads `bundleURL` directly, and the default delegate's implementations only threw or forwarded to each other. Delete the protocol method with those implementations and the factory's dead configuration assignment. The `RCTJavaScriptLoader.h` import stays: removing it breaks every `RCTBridge.h` importer that uses the loader types. Changelog: [iOS][Removed] - Remove deprecated `RCTBridgeDelegate` `sourceURLForBridge:` Reviewed By: javache Differential Revision: D127294778 Pull Request resolved: react#59452
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
sourceURLForBridge:has no callers: the factory readsbundleURLdirectly, and the default delegate's implementations only threw or forwarded to each other. Delete the protocol method with those implementations and the factory's dead configuration assignment. TheRCTJavaScriptLoader.himport stays: removing it breaks everyRCTBridge.himporter that uses the loader types.Changelog:
[iOS][Removed] - Remove deprecated
RCTBridgeDelegatesourceURLForBridge:Reviewed By: javache
Differential Revision: D127294778