Migrate remaining internal deep imports (#58589) - #58589
Closed
rubennorte wants to merge 5 commits into
Closed
rubennorte wants to merge 5 commits into
rubennorte wants to merge 5 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120679643. |
Summary: Replace eligible React Native deep imports in Fantom tests with package exports, Fantom APIs, DOM globals, and types derived from exported symbols. Keep implementation-specific imports where the public surface does not expose equivalent behavior or compatible Flow types. Changelog: [Internal] Differential Revision: D120517166
Summary: Replace Fantom test imports of internal Event, EventTarget, AbortController, and feature flag modules with supported exports and global DOM APIs. Add the missing static Event phase constants to the DOM Flow declarations so constructor constants remain typed, and route trusted-event coverage through `dispatchNativeEvent`. Changelog: [Internal] Differential Revision: D120528709
Summary: Migrate Codegen and compatibility fixtures from React Native deep imports to the public `react-native` entry point. Reference codegen-only types through the exported `CodegenTypes` namespace. Changelog: [Internal] Differential Revision: D120537584
Summary: Migrate the remaining Flow-visible deep imports in React Native tests. Use public DOM globals where their types are sufficient, and use relative imports for implementation-specific helpers, observer types, and native specs that are not publicly exported. Changelog: [Internal] Differential Revision: D120537585
Summary: Pull Request resolved: react#58589 Remove React Native implementation-path imports that are outside the exported GitHub Flow graph but remain visible to the fbsource Flow project. Changelog: [Internal] ___ Reviewed By: cipolleschi Differential Revision: D120679643
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D120679643
branch
from
September 18, 2026 11:35
6fbcd97 to
4954aae
Compare
|
This pull request has been merged in 7d136d6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove React Native implementation-path imports that are outside the exported GitHub Flow graph but remain visible to the fbsource Flow project.
Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D120679643