Skip to content

Use public umbrellas in textinput headers (#58587) - #58587

Open
coado wants to merge 4 commits into
react:mainfrom
coado:export-D120677815
Open

coado wants to merge 4 commits into
react:mainfrom
coado:export-D120677815

Conversation

@coado

@coado coado commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary:

Route public React Native dependencies in exported TextInput framework headers through their supported umbrella headers. Preserve fine-grained includes for same-target, framework-tier, graphics, and third-party dependencies.

Changelog:
[Internal]

Reviewed By: cipolleschi

Differential Revision: D120677815

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 18, 2026
@facebook-github-tools facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Sep 18, 2026
@meta-codesync

meta-codesync Bot commented Sep 18, 2026

Copy link
Copy Markdown

@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120677815.

coado added a commit to coado/react-native that referenced this pull request Sep 18, 2026
Summary:
Pull Request resolved: react#58587

Route public React Native dependencies in exported TextInput framework headers through their supported umbrella headers. Preserve fine-grained includes for same-target, framework-tier, graphics, and third-party dependencies.

Changelog:
[Internal]

Differential Revision: D120677815
@meta-codesync meta-codesync Bot changed the title Use public umbrellas in textinput headers Use public umbrellas in textinput headers (#58587) Sep 18, 2026
Dawid Małecki and others added 4 commits September 21, 2026 07:31
Summary:
Source-built CocoaPods frameworks do not automatically expose the source directories behind stable <React/...> umbrella includes. React-FabricComponents exports modal and text headers that consume umbrellas owned by React-Fabric, React-debug, React-rendererdebug, and React-utils, causing dynamic-framework builds to fail while resolving headers such as <React/RendererCore.h>.

Add the five owning source directories to React-FabricComponents HEADER_SEARCH_PATHS when frameworks and source-built RNCore are used. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework.

Changelog: [Internal]

Differential Revision: D120992289
Summary:
Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled.

Changelog: [Internal]

Differential Revision: D120529435
Summary:
Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the root module with strict API enforcement enabled.

Changelog: [Internal]

Differential Revision: D120532145
Summary:
Pull Request resolved: react#58587

Route public React Native dependencies in exported TextInput framework headers through their supported umbrella headers. Preserve fine-grained includes for same-target, framework-tier, graphics, and third-party dependencies.

Changelog:
[Internal]

Reviewed By: cipolleschi

Differential Revision: D120677815

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant