Skip to content

Add umbrella for react/renderer/graphics subtree #58032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coado wants to merge 7 commits into from
Closed

Add umbrella for react/renderer/graphics subtree #58032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9c828dd
Add umbrella for `react/renderer/components/*` subtree. (#57312)
Aug 20, 2026
52edf04
Add strict API support for `react/renderer/components/*` private targets
Aug 20, 2026
e55bed6
Stop framework headers from exposing private performance APIs
Aug 20, 2026
7b38e3f
Cover 'react/performance' subtree with C++ stable API guards
Aug 20, 2026
72f6f66
Add stable public MapBuffer C++ entry point
Aug 20, 2026
c72adec
Add umbrella for `react/renderer/uimanager` subtree
Aug 20, 2026
08d5784
Add umbrella for `react/renderer/graphics` subtree
coado Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/react-native/ReactAndroid/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ val preparePrefab by
Pair("../ReactCommon/react/renderer/debug/", "react/renderer/debug/"),
// react_renderer_graphics
Pair("../ReactCommon/react/renderer/graphics/", "react/renderer/graphics/"),
Pair("../ReactCommon/react/renderer/graphics/React/", "React/"),
Pair("../ReactCommon/react/renderer/graphics/platform/android/", ""),
// react_renderer_imagemanager
Pair(
Expand All @@ -160,6 +161,7 @@ val preparePrefab by
Pair("../ReactCommon/react/renderer/scheduler/", "react/renderer/scheduler/"),
// react_renderer_uimanager
Pair("../ReactCommon/react/renderer/uimanager/", "react/renderer/uimanager/"),
Pair("../ReactCommon/react/renderer/uimanager/React/", "React/"),
// react_utils
Pair("../ReactCommon/react/utils/", "react/utils/"),
// rrc_image
Expand All @@ -186,6 +188,10 @@ val preparePrefab by
"../ReactCommon/react/renderer/components/root/",
"react/renderer/components/root/",
),
Pair(
"../ReactCommon/react/renderer/components/root/React/",
"React/",
),
// runtimeexecutor
Pair("../ReactCommon/runtimeexecutor/", ""),
// react_renderer_textlayoutmanager
Expand Down Expand Up @@ -248,6 +254,7 @@ val preparePrefab by
"react/renderer/leakchecker/",
),
Pair("../ReactCommon/react/renderer/mapbuffer/", "react/renderer/mapbuffer/"),
Pair("../ReactCommon/react/renderer/mapbuffer/React/", "React/"),
Pair("../ReactCommon/react/renderer/mounting/", "react/renderer/mounting/"),
Pair(
"../ReactCommon/react/renderer/runtimescheduler/",
Expand Down
22 changes: 20 additions & 2 deletions packages/react-native/ReactCommon/React-Fabric.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,16 @@ Pod::Spec.new do |s|
s.subspec "components" do |ss|
ss.subspec "root" do |sss|
sss.source_files = podspec_sources("react/renderer/components/root/**/*.{m,mm,cpp,h}", "react/renderer/components/root/**/*.{h}")
sss.exclude_files = "react/renderer/components/root/tests"
sss.exclude_files = ["react/renderer/components/root/tests", "react/renderer/components/root/React"]
sss.header_dir = "react/renderer/components/root"
end

ss.subspec "rootUmbrella" do |sss|
sss.source_files = "react/renderer/components/root/React/*.h"
sss.header_dir = "React"
sss.header_mappings_dir = "react/renderer/components/root/React"
end

ss.subspec "view" do |sss|
sss.dependency "React-renderercss"
sss.dependency "Yoga"
Expand All @@ -148,7 +154,13 @@ Pod::Spec.new do |s|
ss.subspec "scrollview" do |sss|
sss.source_files = podspec_sources("react/renderer/components/scrollview/**/*.{m,mm,cpp,h}", "react/renderer/components/scrollview/**/*.{h}")
sss.header_dir = "react/renderer/components/scrollview"
sss.exclude_files = "react/renderer/components/scrollview/tests", "react/renderer/components/scrollview/platform/android"
sss.exclude_files = "react/renderer/components/scrollview/tests", "react/renderer/components/scrollview/platform/android", "react/renderer/components/scrollview/React"
end

ss.subspec "scrollviewUmbrella" do |sss|
sss.source_files = "react/renderer/components/scrollview/React/*.h"
sss.header_dir = "React"
sss.header_mappings_dir = "react/renderer/components/scrollview/React"
end

ss.subspec "legacyviewmanagerinterop" do |sss|
Expand Down Expand Up @@ -238,6 +250,12 @@ Pod::Spec.new do |s|
ss.header_dir = "react/renderer/uimanager"
end

s.subspec "uimanagerUmbrella" do |ss|
ss.source_files = "react/renderer/uimanager/React/*.h"
ss.header_dir = "React"
ss.header_mappings_dir = "react/renderer/uimanager/React"
end

s.subspec "leakchecker" do |ss|
ss.source_files = podspec_sources("react/renderer/leakchecker/**/*.{cpp,h}", "react/renderer/leakchecker/**/*.h")
ss.exclude_files = "react/renderer/leakchecker/tests"
Expand Down
6 changes: 6 additions & 0 deletions packages/react-native/ReactCommon/React-FabricComponents.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,12 @@ Pod::Spec.new do |s|
sss.header_dir = "react/renderer/components/modal"
end

ss.subspec "modalUmbrella" do |sss|
sss.source_files = "react/renderer/components/modal/React/*.h"
sss.header_dir = "React"
sss.header_mappings_dir = "react/renderer/components/modal/React"
end

ss.subspec "safeareaview" do |sss|
sss.source_files = podspec_sources("react/renderer/components/safeareaview/**/*.{m,mm,cpp,h}", "react/renderer/components/safeareaview/**/*.h")
# Exclude tests to avoid conflicts with the react-native-safe-area-context package
Expand Down
9 changes: 8 additions & 1 deletion packages/react-native/ReactCommon/React-Mapbuffer.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,21 @@ Pod::Spec.new do |s|
s.platforms = min_supported_versions
s.source = source
s.source_files = podspec_sources("react/renderer/mapbuffer/*.{cpp,h}", "react/renderer/mapbuffer/*.h")
s.exclude_files = "react/renderer/mapbuffer/tests"
s.exclude_files = ["react/renderer/mapbuffer/tests", "react/renderer/mapbuffer/React"]
s.public_header_files = 'react/renderer/mapbuffer/*.h'
s.header_dir = "react/renderer/mapbuffer"
s.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => ["\"$(PODS_TARGET_SRCROOT)\""], "USE_HEADERMAP" => "YES",
"CLANG_CXX_LANGUAGE_STANDARD" => rct_cxx_language_standard() }

s.subspec "MapBufferUmbrella" do |ss|
ss.source_files = "react/renderer/mapbuffer/React/*.h"
ss.header_dir = "React"
ss.header_mappings_dir = "react/renderer/mapbuffer/React"
end

resolve_use_frameworks(s, header_mappings_dir: './', module_name: "React_Mapbuffer")

s.dependency "React-cxxstableapi"
add_dependency(s, "React-debug")
add_rn_third_party_dependencies(s)
add_rncore_dependency(s)
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/performance/cdpmetrics/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ target_include_directories(react_performance_cdpmetrics PUBLIC ${REACT_COMMON_DI
target_link_libraries(react_performance_cdpmetrics
folly_runtime
jsi
react_cxxstableapi
react_performance_timeline
react_timing
runtimeexecutor)
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpInteractionTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <string_view>
#include <unordered_map>

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpMetricsReporter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <ReactCommon/RuntimeExecutor.h>
#include <jsi/jsi.h>
#include <react/performance/timeline/PerformanceEntry.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpPerfIssuesReporter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <ReactCommon/RuntimeExecutor.h>
#include <jsi/jsi.h>
#include <react/performance/timeline/PerformanceEntry.h>
Expand Down
2 changes: 2 additions & 0 deletions ...react-native/ReactCommon/react/performance/cdpmetrics/React-performancecdpmetrics.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ Pod::Spec.new do |s|

resolve_use_frameworks(s, header_mappings_dir: "../../..", module_name: "React_performancecdpmetrics")

s.dependency "React-cxxstableapi"

add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
s.dependency "React-jsi"
s.dependency "React-performancetimeline"
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ target_link_libraries(react_performance_timeline
jsinspector
jsinspector_tracing
reactperflogger
react_cxxstableapi
react_featureflags
react_timing
folly_runtime)
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/CircularBuffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <algorithm>
#include <functional>
#include <vector>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/PerformanceEntry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <react/timing/primitives.h>

#include <optional>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/PerformanceEntryBuffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <vector>
#include "PerformanceEntry.h"

Expand Down
2 changes: 2 additions & 0 deletions ...ages/react-native/ReactCommon/react/performance/timeline/PerformanceEntryCircularBuffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include "CircularBuffer.h"
#include "PerformanceEntryBuffer.h"

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/PerformanceEntryKeyedBuffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <optional>
#include <unordered_map>
#include <vector>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/PerformanceEntryReporter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include "PerformanceEntryCircularBuffer.h"
#include "PerformanceEntryKeyedBuffer.h"
#include "PerformanceEntryReporterListeners.h"
Expand Down
2 changes: 2 additions & 0 deletions ...s/react-native/ReactCommon/react/performance/timeline/PerformanceEntryReporterListeners.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include "PerformanceEntry.h"

#include <folly/dynamic.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/PerformanceObserver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include "PerformanceEntryBuffer.h"
#include "PerformanceObserverRegistry.h"

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/PerformanceObserverRegistry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <memory>
#include <mutex>
#include <set>
Expand Down
2 changes: 2 additions & 0 deletions ...ges/react-native/ReactCommon/react/performance/timeline/React-performancetimeline.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ Pod::Spec.new do |s|

resolve_use_frameworks(s, header_mappings_dir: "../../..", module_name: "React_performancetimeline")

s.dependency "React-cxxstableapi"

s.dependency "React-featureflags"
add_dependency(s, "React-jsinspector", :framework_name => 'jsinspector_modern')
add_dependency(s, "React-jsinspectortracing", :framework_name => 'jsinspector_moderntracing')
Expand Down
2 changes: 2 additions & 0 deletions .../ReactCommon/react/renderer/components/inputaccessory/InputAccessoryComponentDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <react/debug/react_native_assert.h>
#include <react/renderer/components/inputaccessory/InputAccessoryShadowNode.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
Expand Down
2 changes: 2 additions & 0 deletions ...ct-native/ReactCommon/react/renderer/components/inputaccessory/InputAccessoryShadowNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <react/renderer/components/FBReactNativeSpec/EventEmitters.h>
#include <react/renderer/components/FBReactNativeSpec/Props.h>
#include <react/renderer/components/inputaccessory/InputAccessoryState.h>
Expand Down
2 changes: 2 additions & 0 deletions ...s/react-native/ReactCommon/react/renderer/components/inputaccessory/InputAccessoryState.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <react/renderer/core/graphicsConversions.h>
#include <react/renderer/graphics/Float.h>

Expand Down
1 change: 1 addition & 0 deletions ...eact-native/ReactCommon/react/renderer/components/legacyviewmanagerinterop/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ target_link_libraries(rrc_legacyviewmanagerinterop
glog_init
folly_runtime
jsi
react_cxxstableapi
react_renderer_core
rrc_view
yoga
Expand Down
2 changes: 2 additions & 0 deletions ...n/react/renderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropShadowNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

#include <react/renderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropState.h>
Expand Down
2 changes: 2 additions & 0 deletions ...Common/react/renderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropState.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

#import <memory>
Expand Down
2 changes: 2 additions & 0 deletions ...on/react/renderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropViewProps.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/PrivateGuard.h>

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

#include <folly/dynamic.h>
Expand Down
2 changes: 2 additions & 0 deletions ...mponents/legacyviewmanagerinterop/UnstableLegacyViewManagerAutomaticComponentDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

#include <react/renderer/components/legacyviewmanagerinterop/UnstableLegacyViewManagerAutomaticShadowNode.h>
Expand Down
2 changes: 2 additions & 0 deletions ...nderer/components/legacyviewmanagerinterop/UnstableLegacyViewManagerAutomaticShadowNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

#include <react/renderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropViewProps.h>
Expand Down
2 changes: 2 additions & 0 deletions ...components/legacyviewmanagerinterop/UnstableLegacyViewManagerInteropComponentDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

#include <react/renderer/components/view/ConcreteViewShadowNode.h>
Expand Down
2 changes: 2 additions & 0 deletions ...enderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropComponentDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

#include <react/renderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropShadowNode.h>
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/renderer/components/modal/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ target_link_libraries(rrc_modal
folly_runtime
glog_init
react_codegen_rncore
react_cxxstableapi
react_renderer_componentregistry
react_renderer_core
react_renderer_debug
Expand Down
2 changes: 2 additions & 0 deletions ...act-native/ReactCommon/react/renderer/components/modal/ModalHostViewComponentDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/UmbrellaGuard.h>

#include <glog/logging.h>
#include <react/renderer/components/modal/ModalHostViewShadowNode.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewShadowNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/UmbrellaGuard.h>

#include <react/renderer/components/FBReactNativeSpec/EventEmitters.h>
#include <react/renderer/components/FBReactNativeSpec/Props.h>
#include <react/renderer/components/modal/ModalHostViewState.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewState.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/UmbrellaGuard.h>

#include <react/renderer/core/graphicsConversions.h>
#include <react/renderer/graphics/Float.h>
#include "ModalHostViewUtils.h"
Expand Down
Loading
Loading