Skip to content

iOS: reload input views when keyboardType/returnKeyType change on a focused TextInput (Fabric) #57868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NoahDorfman00 wants to merge 1 commit into from
+8 −0
Closed

iOS: reload input views when keyboardType/returnKeyType change on a focused TextInput (Fabric) #57868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .../react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,10 +258,18 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &

if (newTextInputProps.traits.keyboardType != oldTextInputProps.traits.keyboardType) {
_backedTextInputView.keyboardType = RCTUIKeyboardTypeFromKeyboardType(newTextInputProps.traits.keyboardType);
// Without the call to reloadInputViews, the keyboard will not change until the textInput field (the first
// responder) loses and regains focus. Matches the legacy-architecture behavior in RCTBaseTextInputView.
if (_backedTextInputView.isFirstResponder) {
[_backedTextInputView reloadInputViews];
}
}

if (newTextInputProps.traits.returnKeyType != oldTextInputProps.traits.returnKeyType) {
_backedTextInputView.returnKeyType = RCTUIReturnKeyTypeFromReturnKeyType(newTextInputProps.traits.returnKeyType);
if (_backedTextInputView.isFirstResponder) {
[_backedTextInputView reloadInputViews];
}
}

if (newTextInputProps.traits.textContentType != oldTextInputProps.traits.textContentType) {
Expand Down