Make BabelNode* types module-local within @babel/types (remove ambient globals) - #57866
Open
robhogan wants to merge 1 commit into
Open
Make BabelNode* types module-local within @babel/types (remove ambient globals)#57866robhogan wants to merge 1 commit into
@babel/types (remove ambient globals)#57866robhogan wants to merge 1 commit into
Conversation
…ent globals) Summary: Now that all internal and OSS Babel types use explicitly imported types (see stack), modify our Babel type generator scripts and the generated lib defs so that they no longer declare global types. This unblocks migrating to a modern `flowtyped` declaration and removing the `.flowconfig` coupling. Changelog: [Internal] Differential Revision: D114881982
meta-cla
Bot
added
the
CLA Signed
|
@robhogan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114881982. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Now that all internal and OSS Babel types use explicitly imported types (see stack), modify our Babel type generator scripts and the generated lib defs so that they no longer declare global types.
This unblocks migrating to a modern
flowtypeddeclaration and removing the.flowconfigcoupling.Changelog: [Internal]
Differential Revision: D114881982