Fix nougat blank rendering with antialiased border radius clipping - #56336
Closed
Abbondanzo wants to merge 2 commits into
Closed
Fix nougat blank rendering with antialiased border radius clipping#56336Abbondanzo wants to merge 2 commits into
Abbondanzo wants to merge 2 commits into
Conversation
Summary: Rolls out the antialiased clipping code path introduced in #54525 Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D92742063
Summary: Moves `clipRect` inside the outer `saveLayer` in `clipWithAntiAliasing()` to fix blank rendering on API 24 (Nougat) devices. #55762 added `canvas.withClip()` to fix black pixels on partially off-screen views. However, it wrapped the entire compositing chain in an extra `save()`/`clipRect`/`restore()`, creating a triple-nested save/restore stack (`save` -> `saveLayer` -> `saveLayer(DST_IN)`) that breaks Porter-Duff compositing on API 24's HWUI renderer. Moving `clipRect` inside the `saveLayer` reduces nesting from 3 to 2 levels while preserving the black-pixel mitigation. The `saveLayer` already saves and restores clip state, so a separate `save()`/`restore()` wrapper is unnecessary. Changelog: [Android][Fixed] - Fix image content disappearing on API 24 (Nougat) when antialiased border radius clipping is applied Differential Revision: D99677658
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99677658. |
meta-cla
Bot
added
the
CLA Signed
|
This pull request has been merged in fdd6ca5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Moves
clipRectinside the outersaveLayerinclipWithAntiAliasing()to fix blank rendering on API 24 (Nougat) devices.#55762 added
canvas.withClip()to fix black pixels on partially off-screen views. However, it wrapped the entire compositing chain in an extrasave()/clipRect/restore(), creating a triple-nested save/restore stack (save->saveLayer->saveLayer(DST_IN)) that breaks Porter-Duff compositing on API 24's HWUI renderer.Moving
clipRectinside thesaveLayerreduces nesting from 3 to 2 levels while preserving the black-pixel mitigation. ThesaveLayeralready saves and restores clip state, so a separatesave()/restore()wrapper is unnecessary.Changelog: [Android][Fixed] - Fix image content disappearing on API 24 (Nougat) when antialiased border radius clipping is applied
Differential Revision: D99677658