Skip to content

Preserve Expo-generated modulemap in replace-rncore-version.js - #56335

Closed
Insik-Han wants to merge 2 commits into
react:mainfrom
Insik-Han:fix/preserve-expo-modulemap-in-replace-rncore
Closed

Preserve Expo-generated modulemap in replace-rncore-version.js#56335
Insik-Han wants to merge 2 commits into
react:mainfrom
Insik-Han:fix/preserve-expo-modulemap-in-replace-rncore

Conversation

@Insik-Han

@Insik-Han Insik-Han commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Summary

When using Expo with use_frameworks! in the Podfile, Expo generates a React-use-frameworks.modulemap file inside React-Core-prebuilt. When replaceRNCoreConfiguration runs (e.g., when switching between Debug and Release builds), this file can be lost, causing subsequent builds to fail with modulemap-related errors.

The current code removes only directories inside React-Core-prebuilt (preserving top-level files), but React-use-frameworks.modulemap may reside inside one of those subdirectories depending on the Expo version. This PR explicitly saves and restores the modulemap around the directory replacement to make the intent clear and guard against this case.

The restore is placed inside the finally block so it runs even if mv/cp partially fails during the directory move.

Changelog:

[IOS] [Fixed] - Preserve Expo-generated React-use-frameworks.modulemap across replace-rncore-version.js runs

Test Plan

  • Set up an Expo project with use_frameworks! in Podfile
  • Run pod install for a Debug build
  • Switch to a Release build to trigger replace-rncore-version.js
  • Verify React-use-frameworks.modulemap is present in React-Core-prebuilt/ after the replacement
  • Confirm the build succeeds without modulemap-related errors

When using Expo with use_frameworks!, Expo generates a
React-use-frameworks.modulemap file inside React-Core-prebuilt.
This file was lost when replaceRNCoreConfiguration replaced the
directory contents, causing subsequent builds to fail.

Save and restore the modulemap around the directory replacement.
@meta-cla

meta-cla Bot commented Apr 6, 2026

Copy link
Copy Markdown

Hi @Insik-Han!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Apr 6, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 6, 2026
Ensures the Expo-generated React-use-frameworks.modulemap is restored
even when mv/cp partially fails during directory replacement.
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 6, 2026
@meta-codesync

meta-codesync Bot commented Apr 7, 2026

Copy link
Copy Markdown

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D99816864.

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync Bot closed this in ada3922 Apr 8, 2026
@facebook-github-tools facebook-github-tools Bot added the Merged This PR has been merged. label Apr 8, 2026
@meta-codesync

meta-codesync Bot commented Apr 8, 2026

Copy link
Copy Markdown

@cipolleschi merged this pull request in ada3922.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @Insik-Han in ada3922

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants