fix: Hermes prepare_command fails with space in path - #45316
Closed
okwasniewski wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Contributor
Author
|
Hey @cipolleschi can you take a look at this? It's a small fix |
cipolleschi
approved these changes
Jul 18, 2024
cipolleschi
left a comment
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
Thanks @okwasniewski for the fix!
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in fbcb8f6. |
Collaborator
|
This pull request was successfully merged by @okwasniewski in fbcb8f6 When will my fix make it into a release? | How to file a pick request? |
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jul 19, 2026
Embed the helper script in the podspec so CocoaPods executes it from the downloaded Hermes source root without serializing the checkout path. This preserves the quoted-script behavior from upstream react#45316 while making local podspec checksums portable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes a case where the user initializes react native in a directory that contains a space.
It was causing pod install to fail because the path to
create-dummy-hermes-xcframework.shscript wasn't in a string.Changelog:
[IOS] [FIXED] - Hermes prepare_command fails with space in path
Test Plan: