Skip to content

Using Modal in an app with status bar hidden = true results in status bar being shown #8627

Description

@RonakKhandelwal

Bug?

Activity

  1. satya164 commented on Jul 7, 2016

    @satya164
    Contributor

    Please mention your React Native version and platform.

  2. RonakKhandelwal commented on Jul 7, 2016

    @RonakKhandelwal
    Author

    react-native-cli: 0.2.0
    react-native: 0.24.1
    platform: android
    dev platform: macOSX

  3. RonakKhandelwal commented on Jul 8, 2016

    @RonakKhandelwal
    Author

    reproducible????

  4. satya164 commented on Jul 8, 2016

    @satya164
    Contributor

    Can you also post a screenshot? Are you referring to the grey line at the top?

  5. RonakKhandelwal commented on Jul 8, 2016

    @RonakKhandelwal
    Author

    screen shot 2016-07-08 at 3 02 59 pm

    screen shot 2016-07-08 at 3 02 48 pm

  6. RonakKhandelwal commented on Jul 8, 2016

    @RonakKhandelwal
    Author

    the status bar

  7. nihgwu commented on Jul 8, 2016

    @nihgwu
    Contributor

    I think the StatusBar on Modal can't be controlled and will be a blur one on Android right now.
    I remembered there was a PR to add support for translucentStatusBar to Modal but caused test fail, then the PR was not shipped eventually, around 0.27-0.28

  8. nihgwu commented on Jul 8, 2016

    @nihgwu
    Contributor

    Well I noticed that you are using RN0.24, so the StatusBar on Modal will always gray and can't be controlled, after 0.28( or 0.27) it will be a translucent one but still can't make it transparent

  9. nihgwu commented on Jul 8, 2016

    @nihgwu
    Contributor

    Here it is #7157 it was introduced in 0.27

  10. satya164 commented on Jul 8, 2016

    @satya164
    Contributor
  11. nihgwu commented on Jul 8, 2016

    @nihgwu
    Contributor

    @satya164 do you work for 24 hours a day... find you at any time and everywhere, it's crazy

  12. satya164 commented on Jul 8, 2016

    @satya164
    Contributor

    @nihgwu Haha. I try to be online when I can :D

  13. nihgwu commented on Jul 8, 2016

    @nihgwu
    Contributor

    @satya164 It will be so great if you have any time to take a look at this one 1048e5d
    It's really a breaking change and i'm sure it will Influence the others
    I was trapped by that for days before find the cause and revert that commit manually to avoid the issue #8607

  14. nihgwu commented on Jul 8, 2016

    @nihgwu
    Contributor

    actually for this issue, there are two different StatusBar, turn on the hidden prop will hide the StatusBar on the View under the Modal , the showing StatusBar is on Modal and can't be controlled or hidden before RN0.27.
    so it's not an issue for the newest version

  15. satya164 commented on Jul 8, 2016

    @satya164
    Contributor

    @nihgwu Sorry, I've no context on the code.

  16. RonakKhandelwal commented on Jul 8, 2016

    @RonakKhandelwal
    Author

    Ohk so versio issue I guess

  17. kfiroo commented on Sep 8, 2016

    @kfiroo

    @nihgwu I'm having the same issue with RN0.32.0.
    I have a view that hides the status bar and opens a Modal.
    The Modal shows the status bar.
    You said it's not an issue after RN0.27.0 - what did you mean? Can I control the status bar for the modal view somehow?
    Thanks

  18. nihgwu commented on Sep 8, 2016

    @nihgwu
    Contributor

    @kfiroo I've explained #8627 (comment) those are two different StatusBar on View an Modal, you can't control the StatusBar on Modal right now

  19. kfiroo commented on Sep 9, 2016

    @kfiroo

    @nihgwu Ok, I thought you meant that there is a way after RN27 :)
    Thanks!

  20. ShaikhKabeer commented on Jan 11, 2018

    @ShaikhKabeer

    Just go to styles.xml of android/app/src/main/res/values/styles.xml and put this code in Base application theme

    `

    <style name="AppTheme" parent="Theme.ReactNative.AppCompat.Light.NoActionBar.FullScreen"> </style>

    `

    After putting code, remove generated folders from android/app/build/generated folder and again do
    react-native run-android . It will work

  21. netsmertia commented on Mar 3, 2018

    @netsmertia

    I am still facing the same issue. Is there any react-native solution.

  22. thambt commented on May 16, 2018

    @thambt

    @ShaikhKabeer thanks man!. U save me.

  23. locked as resolved and limited conversation to collaborators on May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions