React Pacakger server - getBoolOptionFromQuery error

Using the starter app, the node server fails. I'd submit a fix, but can't sign the CLA right now.

TypeError: Cannot read property 'dev' of null
    at getBoolOptionFromQuery (/Users/idmaffet/react-native/IanTest/node_modules/react-native/packager/react-packager/src/Server/index.js:276:12)

It's an easy fix - just modify the if statement to check if the query object exists

function getBoolOptionFromQuery(query, opt, defaultVal) {
   if (!query||(query[opt] == null && defaultVal != null)) {
     return defaultVal;
   }

  return query[opt] === 'true' || query[opt] === '1';
}

I think your node version is outdated. Can you run node -v?
But we should definitely handle that.

v0.11.14

yes that version of node has a bug with parsing the url query. Here is the correct behavior http://repl.it/fdz/1

On node v0.11.14 it's null. I'll add the fix anyways. Thanks

console.log(
    "should be an object: ",
    url.parse('/path', true).query
);

Thanks for the fast response.

I upgraded node from v0.11.14 to v0.12.1, it works!

The same problem on v0.13.0-pre .

fixed via 0c83766

[react-packager] Fix node v0.11.14 query parse bug

Navigation Menu

React Pacakger server - getBoolOptionFromQuery error #218

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

React Pacakger server - getBoolOptionFromQuery error #218

Description

Activity

amasad commented on Mar 26, 2015

imaffett commented on Mar 26, 2015

amasad commented on Mar 26, 2015

imaffett commented on Mar 26, 2015

lvyile commented on Mar 27, 2015

sosoyososo commented on Mar 27, 2015

amasad commented on Mar 27, 2015

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions