Skip to content

Flow errors on 0.50.3 #16914

Closed
Closed

Description

@joemckie

Is this a bug report?

Yes. Although this may not be RN specific -- it's more of a problem with flow in RN.

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: macOS High Sierra 10.13.1
Node: 9.2.0
Yarn: 1.2.1
npm: 5.5.1
Watchman: 4.9.0
Xcode: Xcode 9.1 Build version 9B55
Android Studio: Not Found

Packages: (wanted => installed)
react: 16.0.0 => 16.0.0
react-native: 0.50.3 => 0.50.3
flow-bin: 0.56.0 => 0.56.0

Target Platform: iOS (10.3)

Steps to Reproduce

Run flow in a RN project

Expected Behavior

Should pass flow checks.

Actual Behavior

Flow errors are being reported from both the metro-bundler package and react-native.

Full list of errors can be found here.

They seem to all be Promise related, but I can't quite work out why. This has only been an issue since upgrading RN@0.50.3.

Reproducible Demo

n/a, not a visual bug.

Activity

  1. ollyde commented on Nov 28, 2017

    @ollyde

    How can they push a release candidate and not even flow check it.

  2. otusweb commented on Jan 26, 2018

    @otusweb

    ./node_modules/.bin/flow version
    Flow, a static type checker for JavaScript, version 0.64.0
    ./node_modules/.bin/react-native --version
    Scanning folders for symlinks in /Users/otusweb/Projects/reactnative/node_modules (13ms)
    0.52.1
    my flow.config is a copy of https://github.com/facebook/react-native/blob/master/local-cli/templates/HelloWorld/_flowconfig at SHA 298f3bb

    Flow returned 24 errors.

  3. react-native-bot commented on Feb 24, 2018

    @react-native-bot
    Collaborator

    Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version?

    I am going to close this, but please feel free to open a new issue if you are able to confirm that this is still a problem in v0.53.0 or newer.

    How to Contribute • What to Expect from Maintainers

  4. added
    Ran CommandsOne of our bots successfully processed a command.
    StaleThere has been a lack of activity on this issue and it may be closed soon.
    on Feb 24, 2018
  5. locked and limited conversation to collaborators on May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Ran CommandsOne of our bots successfully processed a command.StaleThere has been a lack of activity on this issue and it may be closed soon.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions