Skip to content

[Android]Release crash l.View.propTypes.style #16352

Closed
Closed
[Android]Release crash l.View.propTypes.style#16352
Labels
Ran CommandsOne of our bots successfully processed a command.Resolution: LockedThis issue was locked by the bot.

Description

@cbjs
cbjs
opened on Oct 13, 2017

debug is fine, crash while release.

logcat dump.
`
10-13 10:28:08.810 9145 9194 E AndroidRuntime: com.facebook.react.common.JavascriptException: undefined is not an object (evaluating 'l.View.propTypes.style'), stack:
10-13 10:28:08.810 9145 9194 E AndroidRuntime: @1184:5578
10-13 10:28:08.810 9145 9194 E AndroidRuntime: i@2:565
10-13 10:28:08.810 9145 9194 E AndroidRuntime: n@2:348
10-13 10:28:08.810 9145 9194 E AndroidRuntime: t@2:210
10-13 10:28:08.810 9145 9194 E AndroidRuntime: @1183:197
10-13 10:28:08.810 9145 9194 E AndroidRuntime: i@2:565
10-13 10:28:08.810 9145 9194 E AndroidRuntime: n@2:348
10-13 10:28:08.810 9145 9194 E AndroidRuntime: t@2:210
10-13 10:28:08.810 9145 9194 E AndroidRuntime: @1182:113
10-13 10:28:08.810 9145 9194 E AndroidRuntime: i@2:565
10-13 10:28:08.810 9145 9194 E AndroidRuntime: n@2:348
10-13 10:28:08.810 9145 9194 E AndroidRuntime: t@2:210
10-13 10:28:08.810 9145 9194 E AndroidRuntime: @1180:311
10-13 10:28:08.810 9145 9194 E AndroidRuntime: i@2:565
10-13 10:28:08.810 9145 9194 E AndroidRuntime: n@2:348
10-13 10:28:08.810 9145 9194 E AndroidRuntime: t@2:210
10-13 10:28:08.810 9145 9194 E AndroidRuntime: @698:1008
10-13 10:28:08.810 9145 9194 E AndroidRuntime: i@2:565
10-13 10:28:08.810 9145 9194 E AndroidRuntime: n@2:348
10-13 10:28:08.810 9145 9194 E AndroidRuntime: t@2:210
10-13 10:28:08.810 9145 9194 E AndroidRuntime: @309:403
10-13 10:28:08.810 9145 9194 E AndroidRuntime: i@2:565
10-13 10:28:08.810 9145 9194 E AndroidRuntime: n@2:348
10-13 10:28:08.810 9145 9194 E AndroidRuntime: t@2:210
10-13 10:28:08.810 9145 9194 E AndroidRuntime: @12:44
10-13 10:28:08.810 9145 9194 E AndroidRuntime: i@2:565
10-13 10:28:08.810 9145 9194 E AndroidRuntime: n@2:278
10-13 10:28:08.810 9145 9194 E AndroidRuntime: t@2:210
10-13 10:28:08.810 9145 9194 E AndroidRuntime: global code@1260:9
10-13 10:28:08.810 9145 9194 E AndroidRuntime:
10-13 10:28:08.810 9145 9194 E AndroidRuntime: at com.facebook.react.modules.core.ExceptionsManagerModule.showOrThrowError(ExceptionsManagerModule.java:56)
10-13 10:28:08.810 9145 9194 E AndroidRuntime: at com.facebook.react.modules.core.ExceptionsManagerModule.reportFatalException(ExceptionsManagerModule.java:40)
10-13 10:28:08.810 9145 9194 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method)
10-13 10:28:08.810 9145 9194 E AndroidRuntime: at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:363)
10-13 10:28:08.810 9145 9194 E AndroidRuntime: at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:162)
10-13 10:28:08.810 9145 9194 E AndroidRuntime: at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
10-13 10:28:08.810 9145 9194 E AndroidRuntime: at android.os.Handler.handleCallback(Handler.java:754)
10-13 10:28:08.810 9145 9194 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:95)
10-13 10:28:08.810 9145 9194 E AndroidRuntime: at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31)
10-13 10:28:08.810 9145 9194 E AndroidRuntime: at android.os.Looper.loop(Looper.java:160)
10-13 10:28:08.810 9145 9194 E AndroidRuntime: at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:194)
10-13 10:28:08.810 9145 9194 E AndroidRuntime: at java.lang.Thread.run(Thread.java:761)

`

Activity

  1. react-native-bot commented on Oct 13, 2017

    @react-native-bot
    react-native-bot
    on Oct 13, 2017
    Collaborator

    @facebook-github-bot no-template

  2. facebook-github-bot commented on Oct 13, 2017

    @facebook-github-bot
    facebook-github-bot
    on Oct 13, 2017
    Contributor

    Hey, thanks for reporting this issue! It looks like your description is missing some necessary information, or the list of reproduction steps is not complete. Can you please add all the details specified in the Issue Template? This is necessary for people to be able to understand and reproduce the issue being reported. I am going to close this, but feel free to open a new issue with the additional information provided. Thanks! See "What to Expect from Maintainers" to learn more.

  3. facebook-github-bot
    added
    Needs more information
    on Oct 13, 2017
  4. facebook-github-bot
    closed this as completedon Oct 13, 2017
  5. facebook-github-bot
    added
    Ran CommandsOne of our bots successfully processed a command.
    on Oct 13, 2017

  6. timxyz commented on Oct 20, 2017

    @timxyz
    timxyz
    on Oct 20, 2017

    We've been banging our heads against this issue for a few days. Seems like the cause was View.propTypes only being accessible from dev mode, meaning it is undefined in release. The fix is to switch it with ViewPropTypes.

    Quote from View.js:

    // `propTypes` should not be accessed directly on View since this wrapper only
  // exists for DEV mode. However it's important for them to be declared.
  // If the object passed to `createClass` specifies `propTypes`, Flow will
  // create a static type from it.
  propTypes: ViewPropTypes,

  7. pongponglau commented on Oct 21, 2017

    @pongponglau
    pongponglau
    on Oct 21, 2017

    I have the same problem in iOS 10 when running the app in release mode.

    2017-10-21 22:52:35.287874+0800 MyApp[286:15231] Unhandled JS Exception: undefined is not an object (evaluating 'l.View.propTypes.style')

    May i ask if there is any solution?

    Thanks

  8. rcorrie commented on Oct 23, 2017

    @rcorrie
    rcorrie
    on Oct 23, 2017

    In order to solve this, make sure that your app nor any of your dependencies is using View.propTypes.

    @pongponglau

  9. tiberiumihai
    added a commit that references this issue on Nov 6, 2017

    View.propTypes has been deprecated

    0cd64b3

  11. adjieindrawan commented on Mar 20, 2018

    @adjieindrawan
    adjieindrawan
    on Mar 20, 2018

    @timxyz Thank you.. Works for me 🙏

  12. zhaiyjgithub commented on Apr 11, 2018

    @zhaiyjgithub
    zhaiyjgithub
    on Apr 11, 2018

    search the code View.propTypes in your code and your third dependencies.
    in the files:

    1. import {ViewPropTypes} from 'react-native'
    2. replace View.propTypes with ViewPropTypes

    it works for me.

  13. react
    locked as resolved and limited conversation to collaborators on Oct 13, 2018
  14. react-native-bot
    added
    Resolution: LockedThis issue was locked by the bot.
    on Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Ran CommandsOne of our bots successfully processed a command.Resolution: LockedThis issue was locked by the bot.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions