Skip to content

Editorial: style fix and production link fix#138

Merged
Huxpro merged 1 commit into
react:mainfrom
Jack-Works:style
Feb 25, 2022
Merged

Editorial: style fix and production link fix#138
Huxpro merged 1 commit into
react:mainfrom
Jack-Works:style

Conversation

@Jack-Works
Copy link
Copy Markdown
Contributor

This PR only contains non-normative changes. Applies "ignore space changes" will make it easier to review.

Copy link
Copy Markdown
Contributor

@Huxpro Huxpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! This is great!

Other than the question regarding the workflow (I know it's coming from the template), this looks good to merge.

I'm also curious what formatter you are using? The default HTML formatter on VSCode doesn't work for me. I'm using the ECMarkup extension from Ron Buckton for highlighting though.

@@ -0,0 +1,19 @@
name: Deploy spec
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this Github workflow do? Does it build the site for every PR?? That WOULD be great!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's from https://github.com/tc39/template-for-proposals/blob/main/.github/workflows/build.yml

It will automatically build the index.html for you and commit&push to the branch so you won't' forget to build it.

@Jack-Works
Copy link
Copy Markdown
Contributor Author

I'm also curious what formatter you are using?

By my hand 😂

@Huxpro Huxpro merged commit b2f07a7 into react:main Feb 25, 2022
@Jack-Works Jack-Works deleted the style branch February 25, 2022 04:45
Huxpro added a commit to Huxpro/jsx that referenced this pull request Feb 28, 2022
Huxpro added a commit that referenced this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants