Skip to content

Multiple fixes on Android - #724

Merged
manuquentin merged 4 commits into
react-native-webrtc:masterfrom
saif-o99:master
Aug 17, 2023
Merged

Multiple fixes on Android#724
manuquentin merged 4 commits into
react-native-webrtc:masterfrom
saif-o99:master

Conversation

@saif-o99

@saif-o99 saif-o99 commented Aug 15, 2023 •
edited
Loading

Copy link
Copy Markdown

This PR deliver some fixes & new code

1- checkIsInManagedCall was added to check if there is a native active call in android, in my case this was useful to check if there is a native active call, prevent app from making a call

2- onHasActiveCall was added to tell the JS side about native call status, in my case this covered the case where you are in an app call then you accept a native call, this will trigger this event which i end the call by it. so no two calls be on the same time. before, the two calls were running at the same time

3- change in VoiceConnectionService.java is to fix #625

4- onHostDestroy has been added to stop all calls and processes when app is killed

@saif-o99

saif-o99 commented Aug 15, 2023

Copy link
Copy Markdown
Author

@manuquentin Can you please check this? Thanks

manuquentin
manuquentin requested changes Aug 15, 2023
View reviewed changes
Comment thread android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java Outdated
Comment thread android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java Outdated
Comment thread android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java Outdated
Comment thread android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java
Comment thread android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java Outdated
@manuquentin

manuquentin commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

Thanks @saif-o99 , can you please add documentation about the new event ?

@saif-o99

saif-o99 commented Aug 15, 2023

Copy link
Copy Markdown
Author

@manuquentin Done

wilmxre
wilmxre reviewed Aug 16, 2023
View reviewed changes
Comment thread README.md Outdated
@saif-o99
saif-o99 requested a review from wilmxre August 16, 2023 07:52
@saif-o99
saif-o99 requested a review from manuquentin August 16, 2023 07:59
@saif-o99

saif-o99 commented Aug 16, 2023

Copy link
Copy Markdown
Author

hey @manuquentin , is this gonna be merged soon?

@manuquentin
manuquentin merged commit 97f9a6a into react-native-webrtc:master Aug 17, 2023
ramijarrar added a commit to avorra/react-native-callkeep that referenced this pull request Oct 31, 2023
@ramijarrar
Add missing minimum API level annotation
60c2810 
The use of TelephonyCallback was introduced in react-native-webrtc#724.

This is only supported on Android SDK v31+.
ramijarrar added a commit to avorra/react-native-callkeep that referenced this pull request Oct 31, 2023
@ramijarrar
Add missing minimum API level annotation
7f7ff14 
The use of TelephonyCallback was introduced in react-native-webrtc#724.

This is only supported on Android SDK v31+.
@ramijarrar ramijarrar mentioned this pull request Oct 31, 2023
Merged
@dkornilove

dkornilove commented May 13, 2024

Copy link
Copy Markdown

@saif-o99, @manuquentin, the new onHostDestroy behavior should be optional. I spent two days debugging after updating my app dependencies because the foreground service and current call started to disappear when the app is swiped away from recents. So this was unexpected breaking feature for me

@saif-o99

saif-o99 commented May 13, 2024

Copy link
Copy Markdown
Author

@saif-o99, @manuquentin, the new onHostDestroy behavior should be optional. I spent two days debugging after updating my app dependencies because the foreground service and current call started to disappear when the app is swiped away from recents. So this was unexpected breaking feature for me

Sorry to hear that, but the default behaviour of any app is that when you kill the app you kill everything related to it.
try kill for instance Facebook Messenger while in a call. the call will be closed. so having call active while you don't have the app in the background is confusing for the users and seems like a bug.

@dkornilove

dkornilove commented May 13, 2024

Copy link
Copy Markdown

@saif-o99 Speaking for myself, this behavior is unexpected and likely affects others as well. Throughout the library's existence, the behavior has been consistent, and its sudden change without announcement is surprising. I utilize foreground services not only for calls, so it's critical for me that the activity isn't completely killed after closing the app. The foreground service is designed to continue functioning even when the app is closed. Why does a library responsible only for calls override the behavior of the entire application?

mjerris pushed a commit to signalwire/react-native-callkeep that referenced this pull request Oct 16, 2026
@ramijarrar @mjerris
Add missing minimum API level annotation
ab13193 
The use of TelephonyCallback was introduced in react-native-webrtc#724.

This is only supported on Android SDK v31+.

(cherry picked from commit 7f7ff14)
This was referenced Oct 17, 2026
Closed
Merged
mjerris added a commit to signalwire/react-native-callkeep that referenced this pull request Oct 19, 2026
@mjerris @claude
fix(android): onHostDestroy no longer kills the process; ending calls…
dbd3354 
… is optional

onHostDestroy (added by upstream PR react-native-webrtc#724) ended every call and then called
Process.killProcess. The kill ran right after onDisconnect(), before the
posted endCall broadcast reached JavaScript, so the app never hung up its
own media/signalling leg: pressing Back mid-call left the remote call up.
It also crashed the instrumentation runner (react-native-webrtc#797), and users of react-native-webrtc#724 asked
for the behaviour to be optional.

Never kill the process. Ending the calls stays the default, now with the
endCall event delivered; setup({ android: { endCallsOnHostDestroy: false } })
keeps calls running without the activity, as Telecom allows for a
self-managed call. Off-device test that the module no longer references
killProcess and that the setting defaults to true. Typings and README.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mjerris pushed a commit to signalwire/react-native-callkeep that referenced this pull request Oct 19, 2026
@ramijarrar @mjerris
Add missing minimum API level annotation
abdf80c 
The use of TelephonyCallback was introduced in react-native-webrtc#724.

This is only supported on Android SDK v31+.

(cherry picked from commit 7f7ff14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuquentin manuquentin manuquentin approved these changes
+1 more reviewer
@wilmxre wilmxre wilmxre approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CallUUID changes after startCall

4 participants

@saif-o99 @manuquentin @dkornilove @wilmxre