fix: content not visible on js version#731
fix: content not visible on js version#731vonovak wants to merge 1 commit intoreact-native-segmented-control:masterfrom
Conversation
|
currently organizing stuff around ci and example project. |
|
Hey @Naturalclar , I noticed the datetimepicker repo still has a patch to add this fix to segmented-control in their example app. Would you mind if I remade this PR to perhaps remove the need for the patch? |
|
@Saadnajmi sure! That would help out alot! |
No worries, you maintain a lot! (How much stuff exactly? 😅) Happy to help out when/where I can, even if entirely motivated by code I'm currently touching haha. #848 |
Thats like the only time im motivated to touch codes as well haha |
|
@vonovak looks like you can close this now. I'll update my PR to datetiimepicker to remove the patch and pull the new version |
|
released in v2.5.2 🚀 |
Overview
This fixes the appearance of the JS version of the segmented control
screenshots
before
after
Test Plan
I'm not able to test because I'm not able to start up the example app in this repo, but tested this elsewhere