You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
iOS config script phases regression in v14 alpha / react-native 0.75 rc series #2439
I'm attempting to qualify that react-native-firebase works with react-native 0.75 while it is still in the RC phase, and this implies using rn-cli@latest / v14 alphas here
Everything is up to date, which is vague but also true
Description
The platforms.ios.scriptPhases.path item is specified as "a path relative to the package" for script resolution in the docs, and it has always worked that way. The docs indicate an example with ./script.sh or similar, and in fact react-native-firebase uses ./ios_config.sh in our @react-native-firebase/app and @react-native-firebase/crashlytics packages to do some things
In the v14-alpha series here, the relative resolution is no longer package-relative, it is project-relative. What do I mean?
...if you had ./ios_config.sh as your script path in module @react-native-firebase/app:
Previous resolution: <project dir>/node_modules/@react-native-firebase/app/ios_config.sh
Current / v14 resolution: <project dir>/ios_config.sh
It should work, because I use patch-package to patch the react-native-config.js files in @react-native-firebase/app and @react-native-firebase/crashlytics to be regression-compatible with this issue
If you remove those two patch files from the patches directory and re-run ./make-demo.sh it will fail, and the error message will indicate the incorrect path resolution
I attempted to look at the differences between v13 and v14 to see why this is happening so I could just send a new test for this regressed area, and then a PR but I have not been successful at finding it yet. Any help appreciated !
Activity
mikehardy commentedon Jun 28, 2024
This was mis-directed! After logging this I found reactwg/react-native-releases#345
Fixed by react/react-native#45208