fix: page content jump when showMask is false#86
Merged
Conversation
14 tasks
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 71.19% 70.65% -0.55%
==========================================
Files 3 3
Lines 368 368
Branches 138 138
==========================================
- Hits 262 260 -2
- Misses 99 100 +1
- Partials 7 8 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 71.19% 70.65% -0.55%
==========================================
Files 3 3
Lines 368 368
Branches 138 138
==========================================
- Hits 262 260 -2
- Misses 99 100 +1
- Partials 7 8 +1
Continue to review full report at Codecov.
|
afc163
changed the title
Member
|
不对，，showMask 是针对全部类型的，，这样写只针对 right 了。。。 |
jljsj33
reviewed
Apr 29, 2019
| document.body.style.width = `calc(100% - ${right}px)`; | ||
| if (showMask) { | ||
| document.body.style.overflow = 'hidden'; | ||
| document.body.style.width = `calc(100% - ${right}px)`; |
Member
There was a problem hiding this comment.
这样吧...不用 hidden;
if (showMask) {
document.body.style.width = `calc(100% - ${right}px)`;
}
Member
|
当时傻了，脑子没转过来，，没 showMask 时就不应该去处理 body 。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
没有 mask 的时候，页面内容会跳一下。
overflow: hidden和calc(100% - xxpx)应该是成对出现的。